trailsjs / trailpack Goto Github PK

We should set trailpack-datastore/webserver and redirect users to use trailpack/server and trailpack/datastore now
Also we should retrieve tests from those two module and add them here to test those here.

Why was this.log removed from v3. It's breaking some trailpacks.

Issue Description

With last version of Trailpack and smoke signals I have this error :

TypeError: Cannot set property 'smokesignals' of undefined
    at SmokesignalsTrailpack.Trailpack (/Users/jaumard/IdeaProjects/trailpack-annotations/node_modules/trailpack/index.js:51:31)
    at SmokesignalsTrailpack (/Users/jaumard/IdeaProjects/trailpack-annotations/node_modules/smokesignals/lib/trailpack.js:7:10)
    at /Users/jaumard/IdeaProjects/trailpack-annotations/node_modules/trails/index.js:64:59
    at Array.map (native)

Environment

• node version: all
• trails version: all
• operating system: all

Hello!

I've realised that we have the version 2.1.0 in NPM which uses [email protected], and it's giving me this error: 1:1 error Definition for rule 'no-global-assign' was not found no-global-assign

It's reported here already: trailsjs/eslint-config-trails#17

I think this would fix it.

Thank you!

UPDATE: Nevermind, there are a lots of packages with eslint@2 so probably this won't fix it, although any help will be appreciated, I could submit a PR if needed :)

https://github.com/trailsjs/trailpack/blob/master/index.js#L99

I noticed on this line for the on() method, it's using this.app.once.apply(). Would this prevent subsequent events from triggering? What's the difference between the on() method and once() method?

Now env config should be correct on master, but it need to be deploy on npm. @konstantinzolotarev or @tjwebb when you have time :)

There a problem when merging configs here https://github.com/trailsjs/trailpack/blob/master/lib/util.js#L44 cause if trailpacks have Arrays, they're replace and not merged. I have the problem in trailpack-swagger cause I want to add routes.js who add /swagger/doc and /swagger/ui but when I do it all main config/routes are lost and replace by my to swagger routes

defaultsDeep is broken on v4.0.0, put an issue on lodash repo lodash/lodash#1834 don't know how fix this except by get back to the v3.10.0

current archetype index.js file is wrong and confusing

https://github.com/trailsjs/trailpack/blob/master/archetype/index.js

full "blank" default config is here: https://github.com/trailsjs/trailpack/blob/master/config/trailpack.js

Use joi to provide an error to the user if something doesn't match

It can be confusing for the user to see this king of log :

debug: The config setting web.middlewares is defined by both trailpack-express4 and the application. The middlewares config defined in trailpack-express4 will be ignored.
debug: The config setting web.port is defined by both trailpack-express4 and the application. The port config defined in trailpack-express4 will be ignored.
debug: The config setting middlewares.order is defined by both trailpack-express4 and the application. The order config defined in trailpack-express4 will be ignored.

web.middlewares will not be ignored, it's an object so it will be merged.
web.middlewares.order is an array so the log is good
web.port is only an integer so it will be replaced/ignored

Maybe it will be great to only show conflicts logs for Arrays cause it's the only things who matters when merging configs. Other types user know (or don't need to know) there a default config in the trailpack.

It would be nice if assets can be import into trails project from traipacks. For example if I want to create a trailpack who add a generic back office, I want my trailpack to contains views, routes and assets that will be load into my project to have a back office.

Using the trailpack lifecycle configuration it is possible to statically determine which trailpacks are compatible which each other, as well as the order of execution of a set of compatible trailpacks.

Some analysis of this sort can be done after npm install and/or during the trails boot process.