trailheadapps / easy-spaces-lwc Goto Github PK

What is missing from the application? Please describe.
The current configuration of the npm script for running Prettier doesn't work on Windows.

Describe the solution you'd like
Change the format of the prettier commands from using single quotes to escaped double quotes.

Example:

{
        "prettier": "prettier --write \"**/*.{css,html,js,json,md,ts,yaml,yml}\"",
        "prettier:verify": "prettier --list-different \"**/*.{css,html,js,json,md,ts,yaml,yml}\"",
}

What is missing from the application? Please describe.
A clear and concise description of what the problem is. Ex. I'd like to see an implementation of [...]

Describe the solution you'd like
Add instructions for deploying to Trailhead playground. the other sample apps have it but this one just has push for scratch orgs.

Describe alternatives you've considered

Additional context

What is missing from the application? Please describe.
Currently the application uses an Aura component as page template (see here and here).

Describe the solution you'd like
Once page templates are natively available with LWC the Aura wrapper should be removed.

Jest LWC benefits from a wire protocol reform that requires some test code changes.
See this PR for a practical example.

What is missing from the application? Please describe.
Currently the application uses an Aura component for wrapping LWCs that are used in Flow (see here and here).

Describe the solution you'd like
Once the new metadata target is available for flow screens the wrapper should be removed.

Summary

I am having a hard time understanding why the ESBaseStylesLWC unlocked packages should depend on the ESBaseObjects package?

Should we remove the dependency on the objects?

What is missing from the application? Please describe.
The current project does not format Apex using Prettier.

Describe the solution you'd like
The Apex Prettier Plugin has to be implemented to format any Apex related file. That way it aligns with the formatting options in Developer Console.

What is missing from the application? Please describe.
The property enableChangeDataCapture is no longer available in API version 46.0. Objects with that property cannot be deployed.

Describe the solution you'd like
Remove the object property.

What is missing from the application? Please describe.
With Spring '20 a new security option WITH _SECURITY_ENFORCED is available. This is not reflected in the codebase.

Describe the solution you'd like
The code base needs to be checked if/where it makes sense to apply the option.

Describe alternatives you've considered
None.

What is missing from the application? Please describe.
XML formatting is currently not enforced.

Describe the solution you'd like
With Prettier 1.19.x and forward XML support got added. For that the Pretter XML Plugin needs to be added as dev dependency, and the scripts need to be updated.

Prettier should not format auto-generated/internal IDE files like .vscode. This applies to ALL sample apps.

Fix: simply add .vscode to .prettierignore.

What is missing from the application? Please describe.
To reflect UI development best practices the sample app needs to make use of SLDS design tokens that make use of the UI density settings in an org. Similar to that any manual CSS should be replaced, where it makes sense, with SLDS classes instead.

Describe the solution you'd like
Validate all Lightning web components (and Aura, if applicable) if they make use of the latest SLDS design tokens, and if manual CSS syntax needs to be updated with SLDS classes.

The SLDS Validator provides the needed analysis and correction capabilities.

What is missing from the application? Please describe.
Currently, the page architecture for the reservation page and the space designer is pretty complex and hard to understand. We have been running with this app to the SI partners to showcase the app and have overwhelmed our learners by the app complexity.

Also, we have received some more feedback from flow product owners on how complex the design is.

Current Design State

The current design uses lwc, aura, and flows. Flows use lwc embedded in them.

At this point, we are not able to get rid of aura because lwc currently does not support launching flows dynamically. This makes the design complex!

Describe the solution you'd like

We should get rid of the aura completely. This will simplify the design!

What about the dynamic flow launch if we get rid of aura?

For this, the proposal is we use the lightning app builder which allows us to select the flow component. This way we can still show how one could replace the different flow if needed.

proposed state

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

What is missing from the application? Please describe.
The newly introduced local development server for on-platform LWC creates a new local folder within DX projects. That folder holds temporary data.

Describe the solution you'd like
The folder should be excluded from git commits, as the data is only temporary. For that the .gitignore needs to be updated exactly as in this pull request.

Summary

We have several package directories in this app and it would make sense to push them sequentially in order to validate dependencies.
Thankfully, we have a pushPackageDirectoriesSequentially CLI flag that we can use for this:
https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_ws_mpd.htm#mpd-push-source-sequentially

Suggested Solution

No response

Alternative Solutions

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

My Domain is now auto activated in new DE orgs.
Let's remove that step from install instructions.

Problem: each commit to the project outputs this warning:
⚠ Some of your tasks use git add command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

Fix: Current version of lint-staged automates git add action so we need to remove this from package.json:

"*": [
  "git add"
]

What is missing from the application? Please describe.
Currently the application uses Aura components as wrappers to make use of the workspace PAI (see here and for the navigation API (see here and here).

Describe the solution you'd like
Once these APIs are available the Aura components should be replaced with LWC counterparts.

What is missing from the application? Please describe.
The mobileReady property on tabs is no longer supported.

Describe the solution you'd like
Migrate all affected tabs.