What is missing from the application? Please describe.
With Spring '20 a new security option WITH _SECURITY_ENFORCED is available. This is not reflected in the codebase.

Describe the solution you'd like
The code base needs to be checked if/where it makes sense to apply the option.

Describe alternatives you've considered
None.

This is a custom map implemented with leaflet. We should move it to LWC.

Getting the following error when trying ot install any of the trailheadapps apps once one of them is already installed in my dev org:

Package: LWCRecipes (04tB0000000KAfT)
Error Number: 439019472-181616 (1432842097)
Problem:

1. You can’t remove the following public properties: pageNumber,pageSize,totalItemCount, because the component is part of a managed package.
   : You can’t remove the following public properties: pageNumber,pageSize,totalItemCount, because the component is part of a managed package.

What is missing from the application? Please describe.
The current configuration of the npm script for running Prettier doesn't work on Windows.

Describe the solution you'd like
Change the format of the prettier commands from using single quotes to escaped double quotes.

Example:

{
        "prettier": "prettier --write \"**/*.{css,html,js,json,md,ts,yaml,yml}\"",
        "prettier:verify": "prettier --list-different \"**/*.{css,html,js,json,md,ts,yaml,yml}\"",
}

Summary

Make mobile device APIs more discoverable by creating:

• An import contacts page, that allows you to select contacts from your mobile device to import
• A scan property pages, where we'll move the barcode scanner component

Suggested Solution

No response

Alternative Solutions

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Creation of scratch org with the given project-scratch-def.json fails with the error message:

=== Component Failures [1]
[...]
Error shape/settings/LightningExperience.settings settings/LightningExperience.settings Not available for deploy for this API version
ERROR running force:org:create: Failed to deploy settings to scratch org.

After removal of lightningExperienceSettings, the scratch org is created. (sfdx-cli 7.109.0 , scratch org 52.0) The setting appears not to work with an up-to-date environment anymore. Or have I missed anything?!

Summary

If you follow the instructions from the readme here, step 5 (pushing the app) produces the following deployment errors.

Note that this is also a blocker for completing the Set Up the Project on Your Local Machine trailhead module.

*** Pushing with SOAP API v55.0 ***
DEPLOY PROGRESS | ████████████████████████████████████████ | 18/18 Components

=== Component Failures [51]

 Type  Name                Problem
 ───── ─────────────────── ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Error auraPropertyListMap Invalid definition for PropertyController: ApexService.getType() return null with currentNamespace: c, namespace: null, name: PropertyControllerresource leaflet cannot be found in namespace .
 Error asdf                duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error asdf                duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error asdf                duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error barcodeScanner      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error barcodeScanner      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error barcodeScanner      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error brokerCard          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error brokerCard          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error brokerCard          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error daysOnMarket        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error daysOnMarket        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error daysOnMarket        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error errorPanel          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error errorPanel          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error errorPanel          duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error ldsUtils            duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error ldsUtils            duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error ldsUtils            duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error navigateToRecord    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error navigateToRecord    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error navigateToRecord    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error paginator           duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error paginator           duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error paginator           duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyCarousel    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyCarousel    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyCarousel    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyCarousel    Unable to find Apex action class referenced as 'PropertyController'.
 Error propertyFilter      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyFilter      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyFilter      duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyLocation    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyLocation    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyLocation    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyMap         duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyMap         duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyMap         duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertySummary     duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertySummary     duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertySummary     duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTile        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTile        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTile        duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTileList    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTileList    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error propertyTileList    duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error sampleDataImporter  duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error sampleDataImporter  duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error sampleDataImporter  duplicate value found: <unknown> duplicates value on record with id: <unknown>
 Error my_sfdx_project     Cannot find Lightning Component Bundle my_sfdx_project.

ERROR running force:source:push:  Push failed.```

### Salesforce Org Type

Scratch Org

### Steps To Reproduce

_No response_

### Current Behavior

_No response_

### Expected Behavior

_No response_

### Relevant Log Output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

The standard contact card is included, however no sample data is loaded, so it's useless

My Domain is now auto activated in new DE orgs.
Let's remove that step from install instructions.

What is missing from the application? Please describe.
The newly introduced local development server for on-platform LWC creates a new local folder within DX projects. That folder holds temporary data.

Describe the solution you'd like
The folder should be excluded from git commits, as the data is only temporary. For that the .gitignore needs to be updated exactly as in this pull request.

What is missing from the application? Please describe.
To reflect UI development best practices the sample app needs to make use of SLDS design tokens that make use of the UI density settings in an org. Similar to that any manual CSS should be replaced, where it makes sense, with SLDS classes instead.

Describe the solution you'd like
Validate all Lightning web components (and Aura, if applicable) if they make use of the latest SLDS design tokens, and if manual CSS syntax needs to be updated with SLDS classes.

The SLDS Validator provides the needed analysis and correction capabilities.

Cross posting https://github.com/trailheadapps/dreamhouse-sfdx/issues/65

I get

"Unexpected file found in package directory: /Users/.../lwc/dreamhouse-lwc/force-app/main/default/applications/Dreamhouse.app-meta.xml."

when i try to do : sfdx force:source:push

What am i doing wrong?

Currently all the sample properties have the same Date_Listed__c date (TODAY() - 10), and thus the Days_On_Market__c field is always the same. We should improve sample data, to have properties with different dates, so that the daysOnMarket component behavior is clearer.

Remember to change both the sample data in the static resource and the json files.

What is missing from the application? Please describe.
The current project does not format Apex using Prettier.

Describe the solution you'd like
The Apex Prettier Plugin has to be implemented to format any Apex related file. That way it aligns with the formatting options in Developer Console.

Summary

Hey everyone, in the instructions for the app, it gives instructions to optionally install a permission set "Walkthroughs." However, in the permissionsets folder, no such permission set exists; only a "dreamhouse" permission set. So probably want to either add the permission set XML file to the folder, or remove that from the instructions. You get an error when trying to do a push when referencing the missing permission set.

I downloaded the dreamhouse app and when I executed the following command on VS Code to import data

sfdx force:data:tree:import -p ./data/sample-data-plan.json

I got an error for each address stating

errors":[{"statusCode":"REQUIRED_FIELD_MISSING","message":"Required fields are missing: [Street_Address__c]","fields":["Street_Address__c"]}]}

When I changed every instance of "Address__c" in data/properties-data.json to "Street_Address__c" , the problem went away and I was able to import the data just fine.

The Husky pre-commit hook that runs formatting, linting and tests uses shell commands that are not compatible with Windows. These are only working in *nix environments.

Problematic code in package.json:

"precommit": "npm run prettier:verify && [ $? -eq 0 ] && (npm run lint && npm run test) || exit -1"

This issue affects all sample apps.

Jest LWC benefits from a wire protocol reform that requires some test code changes.
See this PR for a practical example.

Prettier should not format auto-generated/internal IDE files like .vscode. This applies to ALL sample apps.

Fix: simply add .vscode to .prettierignore.

Problem: each commit to the project outputs this warning:
⚠ Some of your tasks use git add command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

Fix: Current version of lint-staged automates git add action so we need to remove this from package.json:

"*": [
  "git add"
]

PropertyCarousel component is not referenced anywhere. In the dreamhouse-sfdx version, it was part of the property record page.

Summary

I think the readme needs to be updated to reflect the latest sfdx cli commands.

Steps To Reproduce:

1. Try using the setup steps

Expected result

I should have been able to auth into my dev hub org.

Actual result

Got the warning:

 ›   Warning: auth:web:login is not a sfdx command.
Did you mean force:auth:web:login? [y/n]: 

Additional information

Feel free to attach a screenshot or code snippets.

Situation: Up until Salesforce API got upgraded to 48.0 every time an agent would open a salesforce tab when opening a support case I was able to create a new aura:component that would trigger an init call to the controller creating a div with a unique id and then create a LWC component that contains our bundle.js react code that would look for this unique id and would get inserted in it without affecting any other LWC components that were already rendered (since they have unique ids and the LWC would only get inserted in the div we had just created) and then we would set the LWC component into a div on the cmp on the same init call. Here is the code:

CMP Component: //Here we create the .cmp that will be executed every time a user opens a new tab and where we define where our lwc and div that contains our app will be set to.

 <aura:component implements="flexipage:availableForAllPageTypes
      access="global" controller="auraController">
      <aura:handler name="init" value="{!this}" action="{!c.init}" />
      <aura:attribute name="reactApp" type="Aura.Component[]" access="global"/>
      <aura:attribute name="reactAppBundle" type="Aura.Component[]" access="global" />
      <lightning:card aura:id="reactApp" class="customCardClass">{!v.reactApp}</lightning:card>
      <div aura:id="reactBundle">{!v.reactAppBundle}</div>
    </aura:component>

JS Component: //Here we execute the init call every time a user opens a new tab we assign this div an unique id and then we create the LWC component that will get inserted into this div

init: function(cmp) {
    let id = Math.random()
      .toString()
      .substr(2);


    $A.createComponents(
      [
        ["div", { id: id }],
        [
          “c:lwc",
          {
            Id: id
          }
        ]
      ],
      function(results) {
        cmp.set("v.reactApp", [results[0]]);
        cmp.set("v.reactAppBundle", [results[1]]);
      }
    );
  }

LWC: //Here we get that id that was created in the controller and through the LWC client, we pass it to the React frontend code so it knows what DOM element it needs to get attached to.

export default class lwc extends LightningElement {
  @api id;
  renderedCallback() {
  getSessionId().then(result => {
      this.sessionId = result;
      Promise.all([loadScript(this, app + "/bundle.js")])
        .then(() => {
          window.render(this.id); (this will be used in the frontend code
        })
        .catch(error => {
          console.log(error);
        });
    });
 }
}

React Code: //this is the entry point where we define to what DOM element it should append itself to when the id is received from the LWC client

let renderApp = function (id: any) {
  store.dispatch(setAppClientId(id));
  ReactDOM.render(
    <Provider store={store}>
      <Router>
        <App />
      </Router>
    </Provider>,
    document.getElementById(id ||'root')
  );
};

(window as any).render = renderApp;
The problem: The issue we’re facing is ever since the API got upgraded to 48.0 the same code that was working before it’s no longer working and the problem we’re experiencing is that now when we set the LWC component we just created into the body of the div we also just created it’s setting/overriding the state of all the other LWCs that were already rendered (which is the problem since the state is unique per LWC). We know this from seeing the behavior in the DOM. Sorry if this may be unrelated but thought I'd give it a shot

Summary

After cloning the repo, VSCode's Test Explorer is unable to run the tests in the app.
The tests work when running npm run test:unit in terminal.

Fixed by running npm install jest-environment-jsdom --save-dev.

I can submit a PR with extra dependency if you agree with the approach.

Salesforce Org Type

Scratch Org

Steps To Reproduce

1. Clone the repo
2. Open it with VSCode
3. Run npm install
4. Run npm run test:unit and observe that the tests pass
5. Open VSTest Explorer click on "Run all" icon

Current Behavior

All tests fail

Expected Behavior

All tests pass

Relevant Log Output

● Test suite failed to run

    TypeError: Cannot read properties of undefined (reading 'html')

      at new JSDOMEnvironment (node_modules/jest-environment-jsdom/build/index.js:72:44)

Code of Conduct

• I agree to follow this project's Code of Conduct

What is missing from the application? Please describe.
Currently the application uses an Aura component as page template (see here).

Describe the solution you'd like
Once page templates are natively available with LWC the Aura wrapper should be removed.

What is missing from the application? Please describe.
XML formatting is currently not enforced.

Describe the solution you'd like
With Prettier 1.19.x and forward XML support got added. For that the Pretter XML Plugin needs to be added as dev dependency, and the scripts need to be updated.

Summary

Sample property data is different when imported from CLI or when generated from the UI (Import Data button in the Sample Data Import component).
This can cause issues when completing the Quick Start project because it fails to find an expected sample property when installing the app with a package.

The CLI and Trailhead challenge uses this data:

data/properties-data.json

The UI (package install) uses this data:

force-app/main/default/staticresources/sample_data_properties.json

Recommended fix:

• update property names in the static resource to match the CLI data plan.
• bring back the Tags__c fields in CLI data plan

Steps To Reproduce:

1. Follow readme instructions to install the app via a package and browse properties.
2. Follow readme instructions to install the app via the CLI and browse properties.

Expected result

The two sample data import/generation methods should produce the same data.

Actual result

We have different sample property names.

What is missing from the application? Please describe.
The property enableChangeDataCapture is no longer available in API version 46.0. Objects with that property cannot be deployed.

Describe the solution you'd like
Remove the object property.

Following the instructions to install Dreamhouse using Salesforce DX, I am only getting to 5. Push the app to your scratch org.

$ sfdx force:source:push

PROJECT PATH  ERROR
────────────  ──────────────────────────────
N/A           Invalid version specified:45.0

Using a lower version, e.g. 44.0, returns even more errors.

$ sfdx --version
sfdx-cli/6.49.0 (darwin-x64) node-v10.13.0

What is missing from the application? Please describe.
The mobileReady property on tabs is no longer supported.

Describe the solution you'd like
Migrate all affected tabs.