Comments (7)
Yes it does work with shaderpacks. Noteworthy that I don't test with Optifine since Sodium replaces that. On 1.12.2 culling is also turned off in f5 mode, as the game doesn't even know where the camera is located.
from entityculling.
Any clue why it seems to render all entites with a shader on my setup ?
from entityculling.
Possible that 1.12.2 optifine is weird. As I said, I don't test optifine, but last time I checked it worked fine with optifine shaders in 1.16+. Possible that 1.12.2 optifine renders shaders differently than in "newer" versions. In that case optifine 1.12.2 shaders would be unsupported.
from entityculling.
I've been checking the code, it seems that in CullTask.java, the noCulling boolean seems to change between true and false even when not in 3rd person when a shader is active.
Forcing the boolean to false make the culling working when a shader is active, that's weird 🤔
from entityculling.
Don't have the source open rn, but the noCulling flag on each entity is a vanilla thing. Possible that optifine forces that to true for shadows.
from entityculling.
I'm talking of this line https://github.com/tr7zw/EntityCulling/blob/1.12/EntityCulling-Forge/src/main/java/dev/tr7zw/entityculling/CullTask.java#L58
It's just checking for the third person camera, so shaders in 1.12.2 seems to mess with that.
Also, it is interesting to see that there are two times more skipped entities with a shader. Maybe that can explains poor performances on 1.12.2 with shaders
from entityculling.
I'm talking of this line
So, do you just set it to "false"? I want this fix so bad... I don't mean that the mod's author should do that, but if that solution seems to work, I'll just do it for me and be fine
from entityculling.
Related Issues (20)
- Mod entityculling provides a broken implementation of ModMenuApi - V 1.20.5 HOT 1
- k
- 1.20.5 version is incompatibel with 1.20.6
- Incompatibility with Distant Horizons HOT 3
- [compatibility] 1.20.6: Fabric Tailor HOT 1
- Question: Do I need to disable Sodium culling settings? HOT 3
- ArrayIndexOutOfBoundsException HOT 3
- https://github.com/tr7zw/EntityCulling/issues
- Sodium's option with entity culling mod HOT 1
- 1.21 neoforge: Crashes on launch HOT 2
- Culling Display HOT 1
- Enable Glow effect? HOT 6
- Incompatible with 1.21.1 HOT 9
- Chisel and bits incompatibility HOT 5
- Axolotl swims sideways (and sometimes backwards) HOT 3
- Botania Magic Missile is invisible even though it's in the blacklist
- Rare case where entities are null and Entity iterator counter go nuts :zany_face: HOT 2
- Slowing down elytra boost from fireworks HOT 1
- [Enhancement] Disable Entity Culling When Reloading Chunks HOT 5
- A hard-coded name is used instead of the translation key
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from entityculling.