tower120 / reactive Goto Github PK

It's not a fault of the library, but it'd be great if you could rename foreach to for_each or smth like that. The problem is that Qt has macro foreach and it conflicts with your function

template
void foreach(Closure&& closure) {

as result there are errors in msvc and qt:

master\src\reactive\details\utils\deferredforwardcontainer.h(118): warning C4003: not enough arguments for function-like macro invocation 'Q_FOREACH' (compiling source file QtBindings.cpp)
master\src\reactive\details\utils\deferredforwardcontainer.h(118): error C2988: unrecognizable template declaration/definition (compiling source file QtBindings.cpp)
master\src\reactive\details\utils\deferredforwardcontainer.h(126): note: see reference to class template instantiation 'utils::DeferredForwardContainer<T,DeferredActionValue,ActionListLock,ListMutationLock,unordered>' being compiled (compiling source file QtBindings.cpp)

writing #undef foreach is very annoying before reactive's includes

#include <reactive/ObservableProperty>

is no longer valid. Now it's

#include <reactive/ObservableProperty.h>

2. Just one line

#include <reactive/ObservableProperty.h>

already breaks the build process.

This is yet another so-called 'reactive' library I found, and none simply 'works'. What a shame.

Sorry, I have not found your email, but I'm wondering what is the best way to capture ObservableProperty in lambda? is it better to use by ref, by value or shared_ptr? another question - what is the best way to pass ObservableProperty to function - by ref, by value or shared_ptr?

The problem with static variables inside https://github.com/tower120/reactive/blob/master/src/reactive/details/utils/DeferredForwardContainer.h

Does it mean that user should include reactive headers in cpp only?