touhidurrr / uncivserver.xyz Goto Github PK

The reference server of Unciv, UncivServer, is running at my localhost:8888 in this example.

$ curl "https://uncivserver.xyz/isalive"
true
$ curl "http://localhost:8888/isalive"
{authVersion: 0}

I would highly recommend to return some valid JSON at the /isalive endpoint of your unciv server implementation, even if it's telling you no supported features, like {authVersion: 0} as shown above. At the moment, the client just gives up on parsing the response and uses an empty ServerFeatureSet object, which is fundamentally the same behavior. But I think it would be much cleaner for other client implementations if the response could be parsed.

This would allow a client to "detect broken server implementations" and e.g. show some warning. At the moment, it's just ignored.

Currently, Unciv checks for a 404 return code for custom server implementations.

But UncivServer.xyz returns 409 when a file can't be found. This prevents Unciv from showing a user-friendly message. It also prevents the Android turn check background worker to function correctly, because it also checks for if a file could not be found, and if so, just stops checking them. But if it receives a 409, it thinks that an actual problem has occured and stops everything.

It would be good if UncivServer.xyz could return the HTTP status code 404 when a file is not found.