totorototo / strava Goto Github PK

Define what should be a node, a edge.
What are those made of? what is the link between those?
...

Installation failed on Lollipop.

Todo: check android project setup (sdk, ...).

• build our own system (CI - Android - iOS) to get ride off Cloud solutions (Travis, Bitrise or whatever).

Due to CI modification (travis) Android build configuration files has been modified.
(sign - packaging).

This implies that you have to add ***.keystore file in Android project directory to build debug version.
This is the not way it should be.

FIX Android debug build (sign - pack) + update readme.

there is something fishy in the chain saga, service, helper.

• services are in charge of:

  • formatting data to be passed to an helper,
  • calling helpers,
  • formatting returned data from that helper.

• helpers are generally based promise,

• this is exactly the same for services.

the problem is:

• what if an helper reject a promise?
• how is that handled in services?

PS:
Be aware of what is the return value of .then(): resolve or failure.
Considering the returned value of .then() in both case, we have done something wrong here!
🇿🇲

merge request should build the merge not the branch we want to merge

http://devcenter.bitrise.io/webhooks/trigger-map/

chose and set up CI

• https://github.com/integrations/feature/continuous-integration
• travis https://travis-ci.org/ ??
• biterise ?? http://blog.thebakery.io/continuous-integration-for-react-native-applications-with-fastlane-and-bitrise-ios-version/
• others ...

https://developer.android.com/training/wearables/apps/voice.html

Strava requires that you set an Authorization Callback when creating a Strava App. This is not mentioned in the README documentation for setting up the app. I believe this is causing issues with my ability to successfully authenticate on the initial launch.

see link below:
https://groups.google.com/forum/#!topic/strava-api/P-SnkWvffpg

ClubFeed features affected!

should we use 'Flow'? @guipasmoi

• gpx, kml files loading,
• convert to GeoJSON,
• deal with it 👍

it seems to be related to to react navigation.
Still under investigation.

we have to change in the uri strava for libytometer (may be get it from package.json)

so we need to change redirect uri in

app\routes\screens\login\Login.js

client_id=${Config.CLIENT_ID}&response_type=code&redirect_uri=strava://localhost&scope=public`;

then we will be able to remove app/store/deeplink.js and set deeplinking correctly with react navigation

we should do something to be able to automate testing on devices

• i d like to have snapshots and diff image inside the PR
• ...

We should consider how we should do releases in our CI may be use something like that
https://github-tools.github.io/github-release-notes/examples
https://skywinder.github.io/github-changelog-generator/

https://help.github.com/articles/creating-releases/

https://github.com/prettier/prettier-eslint

https://www.npmjs.com/package/eslint-config-prettier

Use the best of both world!!!

@guijesuis, what do you think?

Evaluate and choose animation libraries:

• airbnb, lottie: https://github.com/airbnb/lottie-react-native

add support for svg
https://github.com/react-native-community/react-native-svg

may be we should consider lfs

https://github.com/blog/1986-announcing-git-large-file-storage-lfs

may be we could use this instead it will allow us to wait for null propagation

https://facebook.github.io/react-native/blog/2017/03/13/idx-the-existential-function.html

This has to be monitored and qualified?
considering switch from watch database children to read data once ?

https://github.com/Intellicode/eslint-plugin-react-native/blob/master/docs/rules/no-unused-styles.md
i think this rule is not activated

we have have to remove react router flux. We can use

• react navigation
• react router v4

revision number should be set foreach artifact.

ps: scripts already created,
ps2: build pipeline has to be modified (bitrise).

Athletes data for a given club could not be retrieved anymore.

Club saga, service and helper has to be updated.
ListClubMember service (normalizr) has to be modified.
ClubMembersCard has to be updated aswell.

Issue while testing the release build of the application.
Got the same behavior on physical device.

Here is the stack trace:

10-26 21:52:25.764 8656 8678 E AndroidRuntime: Process: com.lybitos, PID: 8656
10-26 21:52:25.764 8656 8678 E AndroidRuntime: com.facebook.react.common.JavascriptException: undefined is not an object (evaluating 'u.View.propTypes.style'), stack:
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @687:1062
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:348
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @686:251
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:348
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @408:292
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:348
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @344:253
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:348
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @303:143
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:348
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: @12:38
10-26 21:52:25.764 8656 8678 E AndroidRuntime: i@2:565
10-26 21:52:25.764 8656 8678 E AndroidRuntime: n@2:278
10-26 21:52:25.764 8656 8678 E AndroidRuntime: t@2:210
10-26 21:52:25.764 8656 8678 E AndroidRuntime: global code@1013:9
10-26 21:52:25.764 8656 8678 E AndroidRuntime:
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:56)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:40)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:363)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:162)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:751)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at android.os.Looper.loop(Looper.java:154)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:194)
10-26 21:52:25.764 8656 8678 E AndroidRuntime: at java.lang.Thread.run(Thread.java:761)
10-26 21:52:25.845 1671 2158 W ActivityManager: Force finishing activity com.lybitos/.MainActivity
10-26 21:52:25.858 1304 1304 W SurfaceFlinger: couldn't log to binary event log: overflow.
10-26 21:52:25.881 8656 8673 D EGL_emulation: eglMakeCurrent: 0xa07469a0: ver 2 0 (tinfo 0xa077d8d0)
10-26 21:52:25.975 1671 1877 W InputMethodManagerService: Focus gain on non-focused client com.android.internal.view.IInputMethodClient$Stub$Proxy@11db04d (uid=10091 pid=8656)
10-26 21:52:25.982 1671 5510 I OpenGLRenderer: Initialized EGL, version 1.4
10-26 21:52:25.982 1671 5510 D OpenGLRenderer: Swap behavior 1
10-26 21:52:25.983 1671 5510 W OpenGLRenderer: Failed to choose config with EGL_SWAP_BEHAVIOR_PRESERVED, retrying without...
10-26 21:52:25.983 1671 5510 D OpenGLRenderer: Swap behavior 0
10-26 21:52:25.987 1671 1684 I WindowManager: Failed to capture screenshot of Token{a568e ActivityRecord{e9e2689 u0 com.lybitos/.MainActivity t24 f}} appWin=Window{96e92ec u0 com.lybitos/com.lybitos.MainActivity} drawState=4

After having looking for the root cause for few minutes, it seems the issue comes from:

Card.propTypes = {
children: PropTypes.any,
flexDirection: PropTypes.string,
containerStyle: ViewPropTypes.style,
wrapperStyle: ViewPropTypes.style,
overlayStyle: ViewPropTypes.style,
title: PropTypes.string,
titleStyle: NativeText.propTypes.style,
featuredTitle: PropTypes.string,
featuredTitleStyle: Text.propTypes.style,
featuredSubtitle: PropTypes.string,
featuredSubtitleStyle: Text.propTypes.style,
dividerStyle: ViewPropTypes.style,
image: Image.propTypes.source,
imageStyle: ViewPropTypes.style,
imageWrapperStyle: ViewPropTypes.style,
fontFamily: PropTypes.string,
};

import { View, ViewPropTypes as RNViewPropTypes } from 'react-native';
const ViewPropTypes = RNViewPropTypes || View.propTypes;
export default ViewPropTypes;