totalfreedom / bukkittelnet Goto Github PK

We also need to limit the length of telnet names. If someone connects with a very long name, it will reject the connection and not log it. Insanely long names for telnet can still be a problem.

It needs some limit, as chatting with high lengths can crash anyone who sees the message.

As a response to http://totalfreedom.boards.net/conversation/37590 (limited link).

BukkitTelnet should implement a feature to limit spam. Namely:

• Do not log closing connections for unauthenticated users.
• Prohibit exceptionally long/short usernames, or those containing special characters.

Someone raised this issue to me on Skype:

[4/28/2014 1:53:12 AM | Edited 1:53:30 AM] Ryan (not Barry): Hi Darth, really sorry to bother you but are you aware about the telnet bug? At the moment, there can only be one person connected at a time.

2015-05-14 16:40:00,754 ERROR An exception occurred processing Appender BukkitTelnet java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
at java.util.HashMap$KeyIterator.next(HashMap.java:956)
at me.StevenLawson.BukkitTelnet.TelnetLogAppender.append(TelnetLogAppender.java:54)
at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:99)
at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:425)
at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:406)
at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
at org.apache.logging.log4j.core.Logger.log(Logger.java:110)
at org.apache.logging.log4j.spi.AbstractLogger.info(AbstractLogger.java:1011)
at net.minecraft.server.v1_8_R2.LoginListener$LoginHandler.fireEvents(LoginListener.java:274)
at net.minecraft.server.v1_8_R2.LoginListener$2.run(LoginListener.java:172)
at java.lang.Thread.run(Thread.java:745)

Read more: http://totalfreedom.boards.net/thread/23367/worldedit-crashing#ixzz3a8t0Grgr

See TotalFreedom/TotalFreedomMod#2146

[20:02:32] [Thread-428/INFO]: [BukkitTelnet] (snipped ip) logged in as "".

This happens after someone connects and disconnects. It didn't warn that this was a failed login or anything. It just says "logged in as" - this could be mistaken for a telnet breach.

I suggest that if the user disconnects without supplying a name, that it warns about a suspicious login attempt, or write "[BukkitTelnet] (snipped ip) failed to login."

I suggest stuff like _ to be used in telnet usernames if possible.

Posting this as seen by _Windows' post of
Needs to be either blocked, or filtered in telnet to be readable.

Read more: http://totalfreedom.boards.net/thread/40010/blocking-fancychat#ixzz49RfB8wZl

I suggest, as said, that this somehow be readable by a filter as said.

This is occurring more than once a day on TF now. People are spamming telnet with login requests, with posts suggesting it is being done with LOIC. If you need to see what I mean:

http://pastebin.com/u8AHk9CB

I'm suggesting some sort of fail2ban-esque system to prevent this from happening.

One of the buttons says, Set Limit = 500 but now it sets it to 2500. It is a minor fix for the new update.

Hi.
Is it possible to create a command that can tell who's on telnet?

http://totalfreedom.boards.net/conversation/43969

When I try to connect to my server with the client, It gives me a error that looks like this.

Connecting to 5.135.145.49:1498...
Connection refused: connect
java.net.ConnectException: Connection refused: connect
at java.net.DualStackPlainSocketImpl.connect0(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at org.apache.commons.net.SocketClient.connect(SocketClient.java:182)
at org.apache.commons.net.SocketClient.connect(SocketClient.java:203)
at me.StevenLawson.BukkitTelnetClient.BTC_ConnectionManager$2.run(BTC_ConnectionManager.java:185)
at java.lang.Thread.run(Unknown Source)

Disconnected.

I think it is a error with the port, Can anyone help me?