toreamun / amshan Goto Github PK

Some Kamstrup meters returns null-data in element list.

Thanks to @yurgh for providing test data

Use PEP 585 type annotations. This can be enabled starting in 3.7 with from future import annotations.

You should remove "serial" from the requirements.txt, because "pyserial-asyncio" is based on "pyserial" and not "serial".

Otherwise the installation using "pip install -r requirements.txt" could end up in a namespace conflict between "pyserial" and "serial" like here: espressif/esptool#269

This happened on my Raspberry Pi when installing your project using "pip install -r requirements.txt".
I got the error "... object has no attribute 'serial_for_url'", because it uses "serial" instead of "pyserial"
After removing "serial" from the requirements.txt and setting up the venv completely new (without "serial") it works!

Regards and thanks for your work on this,
Daniel.

Some meters (Kamstrup) seems to send ident line without manufacturer specific identification. This is not by the standard, but must ble allowed to parse Kamstrup.

The time zone offset offset of datetime parsed from COMSEM date-time has wrong direction. A deviation of e.g. -60 becomes -01:00, but should be +01:00.

Spec:

deviation: interpreted as long
range -720...+720 in minutes of local time to UTC
0x8000 = not specified
Deviation highbyte and deviation lowbyte represent the 2 bytes of the long.

Hi Tore,

really nice package!

One question:

Do you have any plans to support "Encrypted DLMS Payload" which I would need to use your package with our Kaifa smart power meter.

[ https://www.tinetz.at/fileadmin/user_upload/Kundenservice/pdf/Beschreibung_Kundenschnittstelle_Smart_Meter_TINETZ.pdf ]
(sorry, general text is only in German, but relevant parts are in English)

Regards,
Daniel.

Reading and decoding of ASCII mode (IEC 62056-21 mode D) telegrams should be supported.