toniov / p-iteration Goto Github PK

In README.md file said license MIT. In package.json file said license ISC. Which statement is true?

Hi,

Thank you for this great library. I have been testing whether to use it or not and it seems to work very well on chrome, Firefox, edge and opera but on safari I get an error. I am using function like your second example

async function getRawResponses (userIds) {
  const responses = await map(userIds, userId => fetch(`/api/users/${userId}`));
  // ... do some stuff
  return responses;
}

The error I am getting is in this section

exports.everySeries = async (array, callback, thisArg) => {
  for (let i = 0; i < array.length; i++) {
    if (i in array && !await callback.call(thisArg || this, await array[i], i, array)) {
      return false;
    }
  }
  return true;
};

at the if statement and error is:

Unexpected identifier 'callback'. Expected ')' to end an if

Have you experienced this issue and if so can it be fixed? Otherwise I need to go with less clean Promise.all option available but I would prefer to use this if possible.

The following error gets thrown from simply loading the library (not even calling it).

Why does this happen? Am using node 8.1.0

import { forEach } from 'p-iteration';

OR

const { forEach } = require('p-iteration');

throws same error:

exports.forEach = async (array, callback, thisArg) => {
                        ^
SyntaxError: Unexpected token (
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)

Would be nice to see a forEach that allowed for parallel execution..

• mapParallel(array, options, callback, [thisArg])
• forEachParallel(array, options, callback, [thisArg])

options

• concurrency: number, min: 1, max: ????
  • The number of in-flight/unresolved concurrent operations to start.

[16:35:09] Error: Couldn't find preset "es2016" relative to directory "C:\src\w-azure\WebSite\w\node_modules\p-iteration" while parsing file: C:\src\w-azure\WebSite\w\node_modules\p-iteration\index.js

I buling project uses
React, Browserify, Babel(es2015), Gulp and others...
I've import P-iteration so have compile error .
I can send project information.
If you have the necessary information, please say me.

Hey @toniov ,

first off, thank you so much for working on this project. It has helped to create great APIs in webdriver.io.

I've seen that this package hasn't seen much updates lately and was wondering what the state of maintenance is. I am currently rewriting the WebdriverIO project from CJS to ESM and have some difficulties using the CJS version of this package. I wonder if you are planning to continue contribute to it or if you like me to take over maintenance on behalf of the WebdriverIO team.

Let me know what you think.

Have a great day!

Thanks for the package! I love the simplicity of the useage!

We've been using p-map as well in some projects but due to the "structure" of it it is sometimes much easier to use your module but in p-map there is a parameter to limit the number of concurrent "threads", {concurrency: 2}

Is the same possible using your module?

Hi!

Would be a super awesome feature if the library would also support types other than plain Arrays that implement Symbol.iterator. If the library would use for ... of internally this could be fairly easy to implement for most methods.

Hi, I'm having an issue when using this library in a react project. The issue seems to that the lib is not ES5 compiled? When trying to build my project, I get the error:

Failed to minify the code from this file: ./node_modules/p-iteration/lib/static-methods.js:11

Could it be something missing on my part?

It is common in libraries like this, to have a chain method, to allow you to use the methods in a chain without aux variables or putting one call inside the other.

Example:

const { chain } = require('p-iteration');

const usersIds = [1, 2, 3];
const users = await chain(usersIds)
  .map(async id => await getById(id))
  .filter(async user => await checkIsActive(user.anotherId))
  .value()

Is it possible to use an async chain?

Hi @toniov! Great stuff with p-iteration! I wanted to share a project I started a while back which is a port of the async.js library to use native promises. All of the methods you've implemented in p-iteration are also available in asyncp. It would be nice to collaborate and work on asyncp together.

jgornick/asyncp

Let me know what you think. Thanks!