ton-blockchain / intellij-ton Goto Github PK

I went in Preferences -> Editor -> Color Scheme -> FunC and tried change Function call foreground color to FFC66D. But the color has changed not only for function calls, but also for their arguments. This looks like a bug.

Suppose I have #include "helpers/constants.func"; in my code. I want to rename folder helpers to utils. So, I suggest that plugin automatically fix #include like in other languages, when I use refactor/rename feature.

Problem:
Every time you have to copy the used schemes from block.tlb
Suggested solution:
Add block.tlb as background import, like stdlib.fc.

I propose to add an IntelIJ trick that allows you to convert strings such as
const int i = 1; to such (int) i() asm "PUSHINT 1" and vice versa.
This will help to refactor the code more conveniently and make it more gas-efficient.

I propose to create a Github Project Board for a more convenient and transparent process of developing a plugin and prioritizing tasks.

Add support for elseif & elseifnot statements.

However, due to a bug in the func compiler, this needs to be added as part of the `if' statement, since such declarations do not work correctly:

if (flag1) {
    do_something1();
} elseif (flag2) {
    do_alternative2();
} elseif (flag3) {
    do_alternative3();
}

that is, the final declaration should look like this:

if (flag1) {
    do_something1();
} elseif (flag2) {
    do_alternative2();
} elseifnot (flag3) {
    do_alternative3();
} else {
    do_alternative4();
}

Additional goals for research

To figure out why the sequential elseif { } elseif { } statement does not work correctly and write an issue to the main ton-blockchain repository and make appropriate changes to the above repository

At the moment, most of the useful checks are not available, due to the fact that the plugin knows nothing at all about typing in the FunC.
The development of a type system will eliminate the need for the most important checks.

Syntax highlight fails on numeric type names

test$_ a:bits900 = 900Bits;

Plugin does not support peeking to a definition of a different nesting level functions other than a level of a current file. Finding functions on the same level works fine.

Would be great to implement this feature.

Plugin version: 0.8.0

There is no validation check when specifying variables in the function signature.

This is valid code :)

FunC compiler may remove "impure" code.

Practically:
a) "impure" modifier present - guarantees correct behaviour
b) "impure" modifier absent - FunC compiler will do strange things, such as strip out some code without your permission.

It will silently remove the function call in two cases:

a) function returns nothing:

() fun() { set_data(begin_cell().end_cell()); }

b) function returns something, but this something is not assigned to anything:

(int) fun() { set_data(begin_cell().end_cell()); return 5; } 
...
int a = fun(); ;; fun is called
fun(); ;; fun call is removed

This is a very bad behavior of FunC compiler, which should be altered. It is ideal to change FunC compiler itself, but that is how it is for now, and it will be good to warn plugin users by highlighting code, which is going to be stripped by the compiler.

Plugin currently doesn't support multiline asm functions using triple quotes (""""). Example:

slice hello_world() asm """
  "Hello"
  " "
  "World"
  $+ $+ $>s
  PUSHSLICE
""";

Docs

https://plugins.jetbrains.com/docs/intellij/code-formatting.html?from=jetbrains.org#external-code-formatter

, , , or '{' expected, got ': short-option'

I propose to add live templates to the most frequently used pieces of code.

Ex:

1. Bounce check bche
   if (flags & 1) { throw(error::bounce()); return (); }
2. recvi

() recv_internal(int my_balance, int msg_value, cell in_msg_full, slice in_msg_body) impure {
    
}

3. recve

() recv_external(slice in_msg_body) impure {
    
}

4. gete

_ my_get_method() method_id {

}

and etc.

I propose to automatically convert such structure languages if (i > b) { throw(error); } to such throw_if(error, i > b); due to the fact that due to the formed habit of programming in other programming languages, the language structure throw_if is not so familiar, but more syntactically correct.

This is valid syntax

Example in Java:

There are two files:

• imports/op-codes.fc (with const op::burn = 0x595f07bc;)
• wallet.fc (uses op::burn)

IDE highlights op::burn in wallet.fc as an unknown identifier:

c#5FE a:(## 32) = AMultiTagInt;
d#3F5476CA a:(## 32) = AMultiTagInt;

This is valid syntax, but highlight will crash

Multiline asms added in version 0.3.0

The extension does not support this and interprets it as an error, because of this the rest of the code formatting breaks

v1.0.3

v2.0-SNAPSHOT+18

Функция test возвращает (int, int, int, cell), в main я принимаю от нее только (int, int, cell), расширение не подсвечивает ошибки.

forall X -> X null() asm "PUSHNULL";

(int, int, int, cell) test () inline {
    return (0, 0, 0, null());
}

() main () {
    (int a, int b, cell c) = test();
    return ();
}

:)

I suggest adding function body generation when writing it, as is done for example in Java.

This will help you write code much faster and more optimally, without being distracted by routine.

Reverse reference not working

https://github.com/tonstack/ton-docs/blob/main/TL-B/README.md#library-usage

When using ton 2.0 in WebStorm, there's an issue where it states it can't find a return at the end of a function if a try-catch block is used.

Need add support native repeat command, so that it works like with a FOR in Java.

https://plugins.jetbrains.com/docs/intellij/uast.html

Expected behaviour:

Actual behaviour:

Create slice "cs", for example:

cell actions;
slice cs = actions.begin_parse();

Type cs.

Expected behavior: suggestions show up
Current behavior: nothing happens

Press Ctrl+Space

Expected behavior: suggestions show up
Current behavior: nothing happens

I propose to add a check for compliance of the returned value with the signature.
Also add a proposal to change the signature, and correct the lines that call this function.

Suggest to improve code reformat in if / else conditions. Will be great ❤️

I suggest adding help writing #include suggesting possibly relevant files for the user.
I also suggest adding a highlight if the include is not used and suggestions for using functions from neighboring .fc files, with the automatic addition of the #include line.

, , , or '{' expected, got ': -ROLL'

• Masterchain
• Workchain
• ADNL
• seqno

Currently plugin doesn't support ternary expressions.

Reference in TON docs: https://ton.org/docs/#/func/statements?id=conditional-operator
Plugin version: 0.7.0

While using multiple conditions, the lexer does not notice the error.
Broken code: (cpu > max_cpu | cpu < min_cpu)
Working code: ((cpu > max_cpu) | (cpu < min_cpu))

The statement lexer needs to be corrected because it does not notice an error in such a line (int sum+= a + b;) when it causes a compilation error. Thus, having a large code, it is easy to miss it.

I propose to change the code generation logic when writing "if" and make it similar to Java, due to the fact that at the moment automatic closing of conditions only creates additional problems.

For now, writing an infinite loop will not throw any error.
I propose to add a separate check that will emphasize this not as an error, but as code that may already cause an error at runtime.

Example in Java:

Adding auto-completion for global variables in smart-contract files. Now it can autocomplete, but only in the file where the variable was defined and without understanding that it is a variable.

Create slice "cs", for example:

cell actions;
slice cs = actions.begin_parse();

Type cs.l (small L) then Ctrl+Space, suggestions show up, but

Current behavior: they include irrelevant suggestions = such that the first parameter of the function is not "slice"
Expected behavior: only relevant suggestions (with first parameter of type "slice") show up

Example in Java: