tomtoolkit / tom_lt Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 0.0 124 KB

Liverpool Telescope facility module for the TOM Toolkit

License: GNU General Public License v3.0

Python 100.00%

tom_lt's People

Contributors

Stargazers

Watchers

tom_lt's Issues

Development timeline

Is there a development timeline for these new features?

Missing Submit button in tom-lt==0.3.0 with tomtoolkit==1.5.0

I set up a tom quickly with the tom-lt module. All standard features out of the box seem to work in the tom. I'm going to dig a bit deeper and get more info.

Declination negative

Pawel Zielinski submitted an observation using tom_lt on target Gaia19dmj.

The Telescope Observed a target at -23 degrees declination as opposed to +23 degrees.

The log was checked on ltproxy at /usr/local/tomcat/logs/catalina.out and the following RTML document had been sent, clearly showing a -ve degree value. This was also reflected in the Phase2 Gaia19dmj target.

2020-05-26 T 17:34:22.245 UTC : org.estar.node_agent2.NodeAgentWebServiceImpl : - : invoked handle_rtml: <RTML xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.rtml.org/v3.1a" mode="request" uid="1590514461" version="3.1a" xsi:schemaLocation="http://www.rtml.org/v3.1a http://telescope.livjm.ac.uk/rtml/RTML-nightly.xsd">
<Project ProjectID="OL20A02">
<Contact>
<Username>XXXXXXXX</Username>
<Name></Name>
</Contact>
</Project>
<Schedule>
<Device name="Sprat" type="spectrograph">
<SpectralRegion>optical</SpectralRegion>
<Setup>
<Grating name="red"/>
<Detector>
<Binning>
<X units="pixels">1</X>
<Y units="pixels">1</Y>
</Binning>
</Detector>
</Setup>
</Device>
<Exposure count="1">
<Value units="seconds">2000.0</Value>
</Exposure>
<Target name="Gaia19dmj">
<Coordinates>
<RightAscension>
<Hours>20</Hours>
<Minutes>5</Minutes>
<Seconds>35.87760000001623</Seconds>
</RightAscension>
<Declination>
<Degrees>-26</Degrees>
<Arcminutes>10</Arcminutes>
<Arcseconds>3.6840000000012196</Arcseconds>
</Declination>
<Equinox>2000.0</Equinox>
</Coordinates>
</Target>
<AirmassConstraint maximum="2.0"/>
<SkyConstraint>
<Flux>4.0</Flux>
<Units>magnitudes/square-arcsecond</Units>
</SkyConstraint>
<SeeingConstraint maximum="2.0" units="arcseconds"/>
<ExtinctionConstraint>
<Clouds>light</Clouds>
</ExtinctionConstraint>
<DateTimeConstraint type="include">
<DateTimeStart system="UT" value="2020-05-27T02:00:00+00:00"/>
<DateTimeEnd system="UT" value="2020-05-27T05:00:00+00:00"/>
</DateTimeConstraint>
</Schedule>
</RTML>

Potential dependency conflicts between tomtoolkit and astropy

Hi, as shown in the following full dependency graph of tomtoolkit, tomtoolkit requires astropy ==4.0, tomtoolkit requires astroplan * (astroplan 0.6 will be installed, i.e., the newest version satisfying the version constraint), and directed dependency astroplan 0.6 transitively introduces astropy >=1.3.

Obviously, there are multiple version constraints set for astropy in this project. However, according to pip's “first found wins” installation strategy, astropy 4.0 (i.e., the newest version satisfying constraint ==4.0) is the actually installed version.

Although the first found package version astropy 4.0 just satisfies the later dependency constraint （astropy ==4.0), such installed version is very close to the upper bound of the version constraint of astropy specified by astroplan 0.6.

Once astroplan upgrades，its newest version will be installed, as tomtoolkit does not specify the upper bound of version constraint for astroplan. Therefore, it will easily cause a dependency conflict (build failure), if the upgraded astroplan version introduces a higher version of astropy, violating its another version constraint ==4.0.

According to the release history of astroplan, it habitually upgrates Astropy in its recent releases. For instance, astroplan 0.2 upgrated Astropy’s constraint from >=1.0 to >=1.2, and astroplan 0.2.1 upgrated Astropy’s constraint from >=1.2 to >=1.3.

As such, it is a warm warning of a potential dependency conflict issue for tomtoolkit.

Dependency tree

tomtoolkit - 1.4.0
| +- astroplan(install version:0.6 version range:*)
| | +- astropy(install version:4.0 version range:>=1.3)
| | +- numpy(install version:1.18.2 version range:>=1.10)
| | +- pytz(install version:2019.3 version range:*)
| | +- six(install version:1.14.0 version range:*)
| +- astropy(install version:4.0 version range:==4.0)
| +- astroquery(install version:0.4.1.dev6017 version range:*)
| +- dataclasses(install version:0.7 version range:*)
| +- django(install version:3.0.5 version range:>=2.2)
| | +- asgiref (install version: version range:=3.2)
| | +- pytz(install version:2019.3 version range:*)
| | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| +- django-bootstrap4(install version:1.1.1 version range:*)
| | +- beautifulsoup4(install version:4.9.0 version range:*)
| | | +- soupsieve(install version:2.0 version range:>1.2)
| | | | +- backports.functools_lru_cache (install version: version range:*)
| +- django-contrib-comments(install version:1.9.2 version range:>=1.9.2)
| | +- django(install version:3.0.5 version range:>=1.11)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- six(install version:1.14.0 version range:*)
| +- django-crispy-forms(install version:1.9.0 version range:*)
| +- django-extensions(install version:2.2.9 version range:*)
| | +- six(install version:1.14.0 version range:>=1.2)
| | +- typing(install version:3.7.4.1 version range:*)
| +- django-filter(install version:2.2.0 version range:*)
| | +- django(install version:3.0.5 version range:>=1.11)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| +- django-gravatar2(install version:1.4.4 version range:*)
| +- django-guardian(install version:2.2.0 version range:*)
| | +- Django(install version:3.0.5 version range:>=2.1)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| +- fits2image(install version:0.4.3 version range:*)
| | +- astropy(install version:4.0 version range:*)
| | +- numpy(install version:1.18.2 version range:*)
| | +- Pillow(install version:7.1.1 version range:*)
| +- matplotlib(install version:3.2.1 version range:*)
| | +- cycler(install version:0.10.0 version range:>=0.10)
| | | +- six(install version:1.14.0 version range:*)
| | +- kiwisolver(install version:1.2.0 version range:>=1.0.1)
| | +- numpy(install version:1.18.2 version range:>=1.11)
| | +- pyparsing(install version:3.0.0a1 version range:>=2.0.1)
| | +- python-dateutil(install version:2.8.1 version range:>=2.1)
| +- numpy(install version:1.18.2 version range:*)
| +- pillow(install version:7.1.1 version range:*)
| +- plotly(install version:4.6.0 version range:*)
| | +- retrying(install version:1.3.3 version range:>=1.3.3)
| | | +- six(install version:1.14.0 version range:>=1.7.0)
| | +- six(install version:1.14.0 version range:*)
| +- python-dateutil(install version:2.8.1 version range:*)
| +- requests(install version:2.23.0 version range:*)
| | +- certifi(install version:2020.4.5.1 version range:>=2017.4.17)
| | +- chardet(install version:3.0.4 version range:>=3.0.2,<4)
| | +- idna(install version:2.9 version range:>=2.5,<3)
| | +- urllib3(install version:1.25.9 version range:>=1.21.1,<1.26)
| +- specutils(install version:0.7 version range:==0.7)

Thanks for your help.
Best,
Neolith

Trivial question

Dear friends,

I am considering the possibility to port this code for a different telescope (REM, http://www.rem.inaf.it/).

Just to better understand, is this code supposed to run on a server managed by the telescope or is it for remote users, i.e. to be downloaded and installed independently of the telescope?

Bye,
Stefano

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.