tomterl / fullframe Goto Github PK

I get the following compilation error:

Warning: the function `gensym' is not known to be defined.

which means I can't use the package. Emacs is 24.3.50.1 (nightly)

I'd like to do something like this:

(fullframe list-packages quit-window :package-fullscreen nil)

but of course quit-window is a very commonly-bound command, and most of the time the advice runs, list-packages will not previously have been called. Can you think of a good way to handle this?

One option, of course, is to wrap up quit-window inside a new package-list-quit-window function, and bind that to q instead, but it seems like we could manage something better... :-)

Would it be possible to add a tag for releases, so that I can run this of melpa stable.

In case of repl-toggle on repeated call of the repl (in this special case ielm for elisp buffers) the first (or second) window configuration is restored when returning from the repl-buffer, not the one active when the repl was called.

ATM interactive functions aren't called interactivly if advised by fullframe. we have to take care that that happens I think.

When using the Magit functionality from the README I get the following errors:

GitHub is eating the traceback, it's here:

https://gist.github.com/bradleywright/7711710

Let's say we have the following config:

(after-load 'magit
  (fullframe magit-status magit-mode-quit-window :magit-fullscreen nil))

Imagine I then run C-u M-x magit-status to view one repo. While viewing that buffer (in which fullframe/--after-advice is, of course, t), I then try to run C-u M-x magit-status to view a different repo.

Result - the command will be completely suppressed, because the ad-do-it clause is not executed.

This is going to take a bit of thought to fix properly. I expect we'll need to get rid of the after-advice var, and instead just look to see if the current buffer's window is already being displayed full-frame...

Introduce a new parameter after-command-on-func, allowing the user to pass a function to fullframe that is called after command-on was run and fullframe did its job.

It would be nice if fullframe acted on generic commands for killing and burying the buffer without configuration. I for instance have:

    (fullframe magit-status magit-mode-quit-window)                                                                                                                                                                                        
    (fullframe magit-status kill-this-buffer)                                                                                                                                                                                              
    (fullframe magit-status kill-current-buffer)                                                                                                                                                                                           
    (fullframe magit-status kill-buffer-and-window)                                                                                                                                                                                        
    (fullframe magit-status kill-other-buffer-and-window)                                                                                                                                                                                  
    (fullframe magit-status magit-mode-bury-buffer nil)                                                                                                                                                                                    
    (fullframe magit-status bury-buffer nil)                          

in my config. 5 of this lines are quite generic and and it's a bit tedious to write it down several time.

Otherwise your tool is quite helpful e.g. when reading mail with notmuch. Thanks for the tool and your attention, Gregor

After updating from melpa, had an error on startup because an argument was ommitted from version< call in fullframe.el at line 113.