Comments (4)
Apologies for the silence; the tests are definitely faulty but reproducing the faults in the test generator has proven to be difficult, and I think that should be a necessary predecessor to spinning up replacement tests. So I'm chasing down whatever dumb error I've made, but definitely agree that there's a real issue here.
from processortests.
Adding ASR
org.opentest4j.AssertionFailedError: ea23 [ASR.b D5, D3] 8
00000c00 ea23 asr.b d5,d3 -- ERROR
Before: M68kState{sr=2700, pc=c00, ssp=800, usp=bf193552, opcode=ea23, dr=[-1993017895, 1358408282, -1554647196, -2067002637, 1042670507, -1816692532, -157755983, 429503768], ar=[-1856226722, -668832212, 8148561, -1033535311, 1922181013, 37470399, 1834068246, 2048]}
Expect: M68kState{sr=2708, pc=c02, ssp=800, usp=bf193552, opcode=0, dr=[-1993017895, 1358408282, -1554647196, -2067002625, 1042670507, -1816692532, -157755983, 429503768], ar=[-1856226722, -668832212, 8148561, -1033535311, 1922181013, 37470399, 1834068246, 2048]}
Actual: M68kState{sr=2719, pc=c02, ssp=800, usp=bf193552, opcode=0, dr=[-1993017895, 1358408282, -1554647196, -2067002625, 1042670507, -1816692532, -157755983, 429503768], ar=[-1856226722, -668832212, 8148561, -1033535311, 1922181013, 37470399, 1834068246, 2048]}
org.opentest4j.AssertionFailedError: e067 [ASR.w D0, D7] 5
00000c00 e067 asr.w d0,d7 -- ERROR
Before: M68kState{sr=2718, pc=c00, ssp=800, usp=c26710aa, opcode=e067, dr=[-1655433306, -905704526, 449956697, 1224506486, 1509593563, -91710300, -379198979, -159666237], ar=[993187654, -1970332476, -242864276, -185075592, -244260028, -464092169, 777736460, 2048]}
Expect: M68kState{sr=2708, pc=c02, ssp=800, usp=c26710aa, opcode=0, dr=[-1655433306, -905704526, 449956697, 1224506486, 1509593563, -91710300, -379198979, -159645697], ar=[993187654, -1970332476, -242864276, -185075592, -244260028, -464092169, 777736460, 2048]}
Actual: M68kState{sr=2719, pc=c02, ssp=800, usp=c26710aa, opcode=0, dr=[-1655433306, -905704526, 449956697, 1224506486, 1509593563, -91710300, -379198979, -159645697], ar=[993187654, -1970332476, -242864276, -185075592, -244260028, -464092169, 777736460, 2048]}
org.opentest4j.AssertionFailedError: e4a0 [ASR.l D2, D0] 6
00000c00 e4a0 asr.l d2,d0 -- ERROR
Before: M68kState{sr=270c, pc=c00, ssp=800, usp=22501cec, opcode=e4a0, dr=[-1428052455, -116602634, -78740867, -727256932, -2019190866, -612557230, -361488192, 382383959], ar=[1200990425, 1839225338, 1263658580, 527953698, 1717863372, -1017905805, -1290803649, 2048]}
Expect: M68kState{sr=2708, pc=c02, ssp=800, usp=22501cec, opcode=0, dr=[-1, -116602634, -78740867, -727256932, -2019190866, -612557230, -361488192, 382383959], ar=[1200990425, 1839225338, 1263658580, 527953698, 1717863372, -1017905805, -1290803649, 2048]}
Actual: M68kState{sr=2719, pc=c02, ssp=800, usp=22501cec, opcode=0, dr=[-1, -116602634, -78740867, -727256932, -2019190866, -612557230, -361488192, 382383959], ar=[1200990425, 1839225338, 1263658580, 527953698, 1717863372, -1017905805, -1290803649, 2048]}
from processortests.
I can confirm that both ASL.b tests cited above are broken for me as well. Analyzing 1583:
00000000 : e502 ASL.B #2,D2
"initial": {
"d0": 1827813764,
"d1": 213778177,
"d2": 3455811518, // 0xCDFB7FBE
"final": {
"d0": 1827813764,
"d1": 213778177,
"d2": 777929476, // 0x2E5E4304
The real output would be 0xcdfb7ff8
. The final value on the test is totally different from the initial.
from processortests.
@TomHarte is the test generator public?
from processortests.
Related Issues (20)
- Something wrong with the 680x0 tests or I don't undestand how it works? HOT 2
- 65816: Incorrect IO cycles for branch instructions in emulation mode HOT 2
- 65816: Incorrect final address for instructions with stack-relative addressing in emulation mode HOT 3
- nes6502 - issue with mirrored memory HOT 5
- 68000 CMPM address register updated before address error? HOT 4
- 68000 test generation and random data HOT 3
- [68000] RTS tests broken HOT 3
- PowerPC chips ?
- Info about 68000 test suite HOT 1
- Bad ADC test(s) for OP 0x69 (immediate addressing) HOT 4
- NES 6502 Incorrect Cycles test HOT 1
- JSR high byte issue HOT 3
- 65816: DBR should not be reset on BRK/COP in emulation mode
- 65816: Emulation mode stack wrapping HOT 2
- 65816: (dp,x) emulation mode page wrapping
- 65816: More emulation mode stack wrapping HOT 2
- Possible wrong cycle count for NES 6502 0C and 1/3/5/7/D/FC HOT 4
- 8088 Test Suite HOT 4
- Inconsistency of the negative flag in decimal mode across 6502 emulators HOT 2
- nes6502 README.md has incorrect sample HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from processortests.