tom24d / eventing-dockerhub Goto Github PK

Context: #7

I have not confirmed yet.

Describe the bug
Transportation success ratio is ~50%.

To Reproduce
Steps to reproduce the behavior:

1. Install DockerHubSource
2. Apply callback-display
3. Apply source with disabledAutoCallback=true
4. docker push
5. See failure ratio on hub.docker.com

Expected behavior
Never fail.

Version info:

• Serving: 0.15.0
• Eventing: 0.15.0
• Kubernetes: 1.16.9-gke.2

Describe the bug

The sample uses

  type: dev.knative.source.dockerhub.push

This conflicts with the sources that are maintained by Knative.

Expected behavior

You should use your own namespacing until this code is donated to Knative to not overlap the eventing namespace.

  type: tom24d.source.dockerhub.push

https://knative.dev/docs/eventing/sources/ which is generated from github.com/knative/docs

Describe the bug
Currently, DockerHubSource reports unnecessary error under specific situation.

To Reproduce
Steps to reproduce the behavior:

1. apply normal-display, callback-display
2. apply source disableAutoCallback=false, sink is normal-one
3. change disableAutoCallback=true, sink is callback-one, apply it
4. See error via kubectl describe

  Type     Reason          Age              From                        Message
  ----     ------          ----             ----                        -------
  Normal   ServiceCreated  70s              dockerhubsource-controller  Created Service "dockerhub-source-p6wpm"
  Warning  InternalError   5s (x2 over 5s)  dockerhubsource-controller  Operation cannot be fulfilled on services.serving.knative.dev "dockerhub-source-p6wpm": the object has been modified; please apply your changes to the latest version and try again
  Normal   ServiceUpdated  5s               dockerhubsource-controller  Updated disableAutoCallback: true

Expected behavior
No error

Version info:

• Serving: 0.15.0
• Eventing: 0.15.0
• Kubernetes: do not remember

As an author, I am curious how many folks are interested in this source.
Currently I am not asking the movement to Source WG.
If you wish you consume this source from knative repo, just leave your stamp here.👀
I will consider about that if this gathers much interest.

context: #37

Please add the link to the Youtube demo in the README

Describe the bug
Currently, DockerHubSource does not work. The pod, that is owned by ksvc owned by applied DockerHubSource, causes CrashLoopBackOff like:
caller: "queue/main.go:393" commit: "12fd001" error: "metrics server failed: listen tcp :9090: bind: address already in use" knative.dev/key: {…} knative.dev/pod: "dockerhub-source-6lt79-mpzk6-deployment-7756896556-bcr4r" level: "error" logger: "queueproxy" msg: "Failed to bring up queue-proxy, shutting down."
and hub.docker.com cannot access to the Receive Adapter.

To Reproduce
Steps to reproduce the behavior:

1. Install DockerHubSource
2. Apply example
3. The error is shown in the queue-proxy container.

Expected behavior
Do not happen.

Version info:

• Serving: 0.15.0
• Eventing: 0.15.0
• Kubernetes: 1.16.8-gke.15

Additional Info
GitHubSource does not cause such an error, so definitely it is not related to the mod.

reuse this: