editor.formatOnSave as well as editor.codeActionsOnSave also edits the code on save.
Some linters and formatters, such as eslint, use editor.codeActionsOnSave, so it's useful to be able to control this setting as well.

I am facing an issue with the "Formatting Toggle" extension in Visual Studio Code. The extension is adding unwanted spaces in my code when formatting is enabled, causing errors in my script.

For months, I've been confused about why formatOnPaste kept getting re-enabled, and I've finally tracked it down to this extension. affects fixes the issue, but it took a lot of digging to find this as the cause.

It would be great if this behavior were either more prominently presented, or if this plugin could somehow infer what affects should be when it's installed.

A few weeks ago, your extension stopped working on all my machines. All I see in the panel is an icon. There are no other errors in the terminal. When i click on the icon, nothing happens. Complete uninstallation VSC and reinstallation did not help.

What could be the problem?

Windows 10 (x64) 1803
VSC 1.62.3
Formatting Toggle (v3.0.0)

Feature Request: Could you please add support to remember my current setting for format on paste?. I use your plugin all the time, this is my pain point is it sets format on paste back to on even if it was turned off before toggling formatting.

I've never had success with the editor.formatOnPaste setting so I have that set to false but this plugin overrides it whenever it is toggled. I'm mostly interested in toggling formatOnSave.

Any thoughts on adding a flag to disable that? I can take a crack at it and open a PR 😄

Currently blocked because VS Code doesn‘t provide a way to check if the change was triggered by the user or programmatically.
I guess we could use a flag to ignore the next event, but this requires to build a simple state system.

This extension doesn't work as intended when you've got workspace settings.

I have a problem with the status bar "Formatting" element - it disappears when I'm switching to a code editor tab from the Extension page in the VS Code Remote instance (Dev containers).

Reproduce steps:

1. Open a remote session (attach to a Docker container)
2. Open the "Formatting toggle" extension page.
3. Click on the "Enable" button.
4. See that the "Formatting" element has successfully appeared in the status bar.
5. Switch to another tab with a code editor.
6. See that the "Formatting" element has disappeared in the status bar.
7. Use the "Toggle formatting" action in the command palette to switch the mode.
8. See that the "Formatting" element has again successfully appeared in the status bar.
9. Switch to another tab with a code editor.
10. See that the "Formatting" element has disappeared in the status bar again.

It also appears back if I disable the extension, then reload, and enable it again. But still until I switch the current tab.

On the local instance (without Remote) it works well.

Could you please try to reproduce this on your side and invent some fix for it? Thanks!

To ESLint - https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
you need to specify the property:

"editor.codeActionsOnSave": {
"source.fixAll": true
}

instead of formatOnSave

would be nice to have an icon for this extension.

Thank you for make this great extension, but preprocess intructions in c++ doesn't indent properly, blocks start with # are always formatted to start at the beginning of the line:

void ExampleMethod()
{
	if (1)
	{
#if DEBUG
		int value = 0;
#endif
	}
}

I suppose it should be better if they are indented to desired level :

void ExampleMethod()
{
	if (1)
	{
	#if DEBUG
		int value = 0;
	#endif
	}
}

or:

void ExampleMethod()
{
	if (1)
	{
		#if DEBUG
		int value = 0;
		#endif
	}
}

or:

void ExampleMethod()
{
	if (1)
	{
		#if DEBUG
			int value = 0;
		#endif
	}
}

It's just Formatting: <checkmark icon> - so I have no idea if it is toggled on or off, nor how I can toggle it. Note it does not change when I run CMD + Shift + P and select "Toggle Formatting".

Issue Type: Bug

extension bisect identified as a problem extension

Extension version: 2.0.0
VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19042

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt678:30270856
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554:30281908
pythontb:30283811
openwsldoc:30282072
vspre833:30267464
pythonptprofiler:30281270
vshan820:30276952
pythondataviewer:30285071
vscus158cf:30286554

There are a lot of VSCode settings that makes IDE format the code on save:

• editor.formatOnSave
• editor.codeActionsOnSave (#54)
• files.trimTrailingWhitespace
• files.trimFinalNewlines
• and even more...

Also extensions can format documents via vscode.workspace.onWillSaveTextDocument. I don't think it can be disabled with any setting.

It is much easier and more reliable to disable any possible formatting via overriding ctrl+s shortcut to workbench.action.files.saveWithoutFormatting.

I propose to add a boolean setting which would also enable this behavior.

I'd like to implement this, however I still in doubt how we can write to keybindings.json.
AFAIK we don't have direct access to neither settings.json nor keybindings.json via API, but we want this to also work in web.

Could you please add support for toggling the following options, which is also tied to formatting?

• files.insertFinalNewline
• files.trimFinalNewlines
• files.trimTrailingWhitespace (microsoft/vscode#13157, which is my intention to open this issue)

Thanks for your extension 🙂

That would be nice to have an option formattingToggle.deactivateFor, in my case I would like to disable formatOnSave but keep formatOnPaste and formatOnType when I'm contributing to existing code.

Thanks

Toggle is not working.

I get following error when trying to toggle:
ERR Unable to write to User Settings because formatOnSave is not a registered configuration.

I have editor.formatOnSave set on user settings to be able to sync with my home preferences and also have it set on workspace settings to make some settings default for our company workspace.

Apparently it only takes the user settings in consideration, because once I disable editor.formatOnSave manually on my workspace settings it works as it should.

It happens using prettier on ts and beautify in html files

Originally posted by @Tom-Bonnike in #47 (comment)

I’ll close this, happy to reconsider if more people want something like this

As the other poster requested, please add "deactiveFor" to allow us to configure the behaviour to our liking.

As for the value, here is my scenario:

1. I've configured editor's formatOnPaste and formatOnType to be always true.
2. I want "formattingToggle" button to only affect formatOnSave (toggle on and off)

Why 1)?
Cause for the code I edit (i.e. paste and type), I want it nice and organized.

Why 2)?
Cause not everyone uses VScode. In a big company, on a big project, there are tons of people writing code, and not always following formatting guides (whether I should re-format everyone else's file is outside the scope of this discussion). So, majority is existing code is not formatted to the same standards

If, every time I modify a single line for a fix and save, it will reformat the whole file, it will make huge changes on commits, resulting in potential conflicts on many lines when merged back to other branches (with other non-formatting people working on same files). So no, I don't want "formatOnSave" to be on when working on collaborative work (but I still want my changes formatted, so I have editor setup to always format on paste and type)

But when working on my own files, I want to toggle "formatOnSave" to true.

Yes, I could achieve this through different .vscode per-workspace files... Or through that other extension that binds keyboard shortcuts to different settings....
But the whole point of the quick status bar toggle is to avoid setting up custom workspace settings per each folder I work on, and to avoid remembering keyboard shortcuts.

We are not asking to change default behaviour. We are asking to give us the option to configure our custom behaviour.

Thank you.

Maybe I'm missing a way this can work out the box but if not it would be great if you could support the toggling of format on save when you are using it scoped to each language. Doesn't seem to be able to toggle it currently.

"editor.formatOnSave": false,
"[php]": {
  "editor.formatOnSave": true
},
"[javascript]": {
  "editor.formatOnSave": true
}

I had to work around a similar situation so just to possibly save you a couple minutes of looking it up, this is how I went about checking for it. Using the always handy lodash has and get methods.

const config = vscode.workspace.getConfiguration();
if (has(config, '[php]')) {
  const phpScopedObj = get(config, '[php]');
  if (phpScopedObj['editor.formatOnSave']) {
    // Things to do when it exists.
  }
}

You would really make my day if you could somehow work out a way to toggle these as well, I haven't found anything yet to cover this situation and it gets old editing the settings file everytime so I don't polute the git logs of older sites without explicit formating settings in them with a bunch of formatting changes from my user settings.

Settings should:

• Be toggled to undefined when not previously specified in the user’s config, false otherwise
• Be toggled to true only if they are specified in the user’s config

It would be excellent if one could define the text accompanying $(check) and $(x) in the Status Bar.

I'm also curious if anyone would be interested in customizing the icons, as well. Personally, I quite like $(check) and $(x).

First thanks for such a great plugin.

Do it uses prettier or what? How do I identify it bro? Currently I was having problem with laravel blade so It will be easy for me :) Is there way I can customize the formatting .

Version: 1.85.0
Formatting Toggle v3.2.0

I was using the Status Bar Toggle Button to disable autoformatting on file save. However, that stopped working.
Could this be due to changes in a recent VS Code Update?
One thing I noticed is, that I have the setting on workspace level, not on user level. However the toggle is active but does not toggle…

Thank you for developing this very nice plugin
Please can your make it not to remove an object property with a string key
like that $route thanks

<script>
export default {
  name: "app",
  methods: {
  aMethod(to, from){
}

},
  watch: {
   "$route": "aMethod"
  }
};
</script>

If you set "editor.formatOnSave" to true in workspace settings, you can no longer use this extension to toggle formatting.

It will always be true no matter how many times you click the icon on status bar.

When I hit the button, nothing happens.

VSCode 1.49.1

With multiple vscode windows open if you toggle it in one it effects the other. This will also result in a inconsistent state where one window will show "formatting:x" indicating disabled when in fact its enabled and vice versa.

Regardless of toggle (via clicking on the "formatting" in the bottom right corner), it formats.

I'm using "React native tools" which include Beautify.

This is happening in a .js code file listed as "JavaScript React".

Not sure what information you require to determine the problem.

vscode: 1.25.1
user settings:
"editor.formatOnSave": false,
"files.autoSave": "afterDelay",
"files.associations": {
"*.js": "javascriptreact"
},
"emmet.includeLanguages": {
"javascript": "javascriptreact"
},
"emmet.triggerExpansionOnTab": true,
"prettier.singleQuote": true,
"javascript.validate.enable": false,

Hi,

Thank you for your extension. I use it all the time to switch between personal and professional projects.

In this case, it might be nice to have an option to have the extension turn off formatting only for the workspace or folder scope.

For example, in my work, projects use only Eslint on the command line for formatting, which works fine.
In my personal projects, I have all the tools configured: Eslint, Prettier, Stylelint... that I don't want to disable manually one by one and depending on the projects.

Another example, in some cases you want to disable formatting just because it creates multiple diffs on a file, but you don't want to disable formatting across all your vscode windows for that!

See update doc: https://code.visualstudio.com/docs/extensionAPI/vscode-api#_a-nameworkspaceconfigurationaspan-classcodeitem-id988workspaceconfigurationspan
Workspace or WorkspaceFolder doesn’t seem to work.