tobiipro / babel-preset-firecloud Goto Github PK

test by building schemata-firecloud, which with @babel/[email protected] fails with

09:32:23 [INFO] Generating dts/atex-beacon-in-view-event-v1-json.d.ts...
error SyntaxError: Unexpected token W in JSON at position 1
    at JSON.parse (<anonymous>)
    at /Users/andrei/git/firecloud/schemata-firecloud/node_modules/json-schema-to-typescript/dist/src/cli.js:70:33
    at step (/Users/andrei/git/firecloud/schemata-firecloud/node_modules/json-schema-to-typescript/dist/src/cli.js:33:23)
    at Object.next (/Users/andrei/git/firecloud/schemata-firecloud/node_modules/json-schema-to-typescript/dist/src/cli.js:14:53)
    at fulfilled (/Users/andrei/git/firecloud/schemata-firecloud/node_modules/json-schema-to-typescript/dist/src/cli.js:5:58)

see https://github.com/ziolko/babel-plugin-auto-await

in its current form https://github.com/tobiipro/babel-preset-firecloud/blob/7d4447cd3bf4aad4857c346a8c794f72be0485ca/plugins/babel-plugin-firecloud-src-arg.js this plugin can work even when no srcFuns are given in the config.

One could argue though that you anyway have to provide srcFuns in order to make this plugin useful, so it's not a big deal to provide also disabled: false.

NOTE A negative side-effect. While debugging, Chrome won't be able to get the value of an exported variable, because the source map will reference exports.something, while you still hover something.

__filename is available in node and webpack, and it would provide an absolute path, instead of a scoped one

regardless of the state of #2 , we should be consistent with

• exporting or not non-api vars in a module
• marking non-api vars with an underscore prefix or not

PS: this is a TODO for all the repos we now have on github, not a real issue for this repo

Jest mocks do not allow accessing vars from the outer scope, which exports is. Also, other weird errors occur, which I don't really want to dig into. Already wasted too much time on this...

One of the most simple and clean solutions IMO is to use different envs for dev and test in .babelrc. I managed to get it working pretty easy, since jest sets NODE_ENV=test and this one is used by Babel to pick config. We have this variable in our makefile, but it's not exported, so gets redefined by jest. Another level of control is to use BABEL_ENV variable, which has higher priority.

Let's discuss in the office how we want to tweak these vars to make it work properly.

Case like let _ = require('lodash-firecloud');
Otherwise, we can get in the end exports._.merge(...