to-kr / luacov-multiple Goto Github PK

Files with dashes in their names generate incorrect directory names that include the filename, and result in 404s when browsing the report HTML.

The issue is caused by an unescaped string.gsub() call in html.lua:55

I've submitted a PR with the fix

What happened

Github just rolled out a change to their protocol security today: https://github.blog/2021-09-01-improving-git-protocol-security-github/, effectively disabling unauthenticated access using git:// protocol.

Steps to reproduce

sudo luarocks install luacov-multiple

Output:

Installing https://luarocks.org/luacov-multiple-0.4-1.rockspec
Missing dependencies for luacov-multiple 0.4-1:
   lustache (not installed)

luacov-multiple 0.4-1 depends on lustache (not installed)
Installing https://luarocks.org/lustache-1.3.1-0.rockspec

lustache 1.3.1-0 is now installed in /usr (license: MIT <http://opensource.org/licenses/MIT>)

Cloning into 'luacov-multiple'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Error: Failed cloning git repository.

If the code contains multiple empty lines in sequence the HTML output will display them as only one empty line.
This causes that the "hits" and "line number" columns are longer than the "code" column and show the hits in the wrong lines.

I could fix this by modifying the HtmlReporter as follows:

function HtmlReporter:on_empty_line(filename, lineno, line) -- luacheck: no unused args
	local line = tools.rtrim(line)
	if (line == "") then
	  line = "\n"
	end
	table.insert(self.current_class.lines, { number = lineno, hits='-', hitsText=' ', line = line })
end

With this fix the empty lines are displayed properly in Firefox and Chromium.

When a file has more than 1 consecutive blank line, they are collapsed into a single line (because blank lines are displayed in inline divs). This completely messes up the line alignment with counts and line numbers.