tmtsoftware / csw-prototype Goto Github PK

The type of the first argument of scheduleOnce() and schedule() of TimeService should be LocalDateTime, not LocalTime. During night observations, the date changes. With LocalTime, we cannot distinguish whether that time is the time of the day when scheduleOnce() method is called, or the time of the next day.

This issue should have been made in the icd project...

Executing install.sh does not appear to install the conf file that it is checking for.

A request from DKerley.

In a multi-user environment it is not possible to use csw-services.sh as it assumes the same directories, in particular:

/tmp/csw # for service lock and log files
/tmp/CsTestOversize
/tmp/CsTestMainRepo

Some suggestions:

• Have the possibility to have a single, system-wide Redis instance running that multiple instances of the various services could share.
• Barring the above, allow for multiple instances of Redis running on different, configurable ports for each user.
• Use different directories in /tmp for all of the ephemeral service and test data (e.g., partition by username).
• If a single top-level directory is used for all users, e.g., /tmp/csw, ensure that it has +rwx permissions when it is initially created.

In addition, there is a small change that may help new users trying to run tests. If CSW_INSTALL is incorrectly set, but points to an existing directory, csw-services.sh will fail silently. It would be helpful to add tests for the existence of $CSW_INSTALL/bin/[all service executables] and then exit with bad status and display a message to the user.