tj-actions / coverage-badge-go Goto Github PK

Is this feature missing in the latest version?

• I'm using the latest release

Is your feature request related to a problem? Please describe.

I'll like to specify a path to the coverage output

Describe the solution you'd like?

Using path instead of filename would be a preferred input name that communicates support for paths i.e sub project coverage.

Describe alternatives you've considered?

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

The below script works properly, creating a commit with updated coverage info in README.md. The problem is that the Pull Request is not able to be merged because the badge commit is not signed:

Merging is blocked
The base branch requires all commits to be signed.

My coverage_badge.yml

# https://github.com/tj-actions/coverage-badge-go
name: "Coverage Badge"
on:
  pull_request:
    branches:
      - develop

jobs:
  test:
    runs-on: ubuntu-latest
    name: Update coverage badge
    steps:
      - name: Checkout
        uses: actions/checkout@v3
        with:
          persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal access token.
          fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository.

      - name: Setup go
        uses: actions/setup-go@v3
        with:
          go-version: "1.18"

      - name: Install OS dependencies
        run: sudo apt-get update && sudo apt-get install libgl1-mesa-dev xorg-dev

      - uses: actions/cache@v3
        with:
          path: ~/go/pkg/mod
          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
          restore-keys: |
            ${{ runner.os }}-go-

      - name: Run Test
        run: |
          go test -v ./... -covermode=count -coverprofile=coverage.out
          go tool cover -func=coverage.out -o=coverage.out

      - name: Go Coverage Badge # Pass the `coverage.out` output to this action
        uses: tj-actions/coverage-badge-go@v2
        with:
          filename: coverage.out

      - name: Verify Changed files
        uses: tj-actions/[email protected]
        id: verify-changed-files
        with:
          files: README.md

      - name: Commit changes
        if: steps.verify-changed-files.outputs.files_changed == 'true'
        run: |
          git config --local user.email "[email protected]"
          git config --local user.name "GitHub Action"
          git add README.md
          git commit -m "chore: Updated coverage badge."

      - name: Push changes
        if: steps.verify-changed-files.outputs.files_changed == 'true'
        uses: ad-m/github-push-action@master
        with:
          github_token: ${{ github.token }}
          branch: ${{ github.head_ref }}

To Reproduce

1. Add above script to project and commit
2. Create a PR on a branch that requires commits to be signed
3. Observe that GitHub will not allow the PR to be merged

What OS are you seeing the problem on?

macos-latest or macos-10.15

Expected behavior?

I expected the commit to be signed

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

when use the yml file you provide, workflow will exit with this message

To Reproduce

when i change go version to 1.17, error will disappear.

What OS are you seeing the problem on?

all

Expected behavior?

fix this

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

In your doc, you are using the wrong id for verify-changes:

    if: steps.changed_files.outputs.files_changed == 'true'

Should be:

    if: steps.verify-changed-files.outputs.files_changed == 'true'

To Reproduce

See doc

What OS are you seeing the problem on?

all

Expected behavior?

    if: steps.verify-changed-files.outputs.files_changed == 'true'

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• chore(deps): update actions/checkout digest to 692973e

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update codacy/codacy-analysis-cli-action action to v4.4.5
• chore(deps): update peter-evans/create-pull-request action to v6.1.0
• chore(deps): update tj-actions/verify-changed-files action to v20
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

why my badge generated not in % form

To Reproduce

use your .yml

What OS are you seeing the problem on?

all

Expected behavior?

become % form.

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct