Giter Club home page Giter Club logo

Comments (6)

UXVirtual avatar UXVirtual commented on May 24, 2024 3

A fix is now available in PR #29

from aframe-orbit-controls-component.

UXVirtual avatar UXVirtual commented on May 24, 2024

After further investigation, I narrowed down the offending commit to:

aframevr/aframe@5214a16

It's likely that the change in here is causing a conflict in the way that aframe-orbit-controls-component is binding its event listeners.

from aframe-orbit-controls-component.

UXVirtual avatar UXVirtual commented on May 24, 2024

I have a working fix for this - you need to swap out the event listener for render-target-loaded to renderstart. Then it will be able to bind events to the canvas correctly. Will do a PR once I've finished testing this out in my production project.

from aframe-orbit-controls-component.

tizzle avatar tizzle commented on May 24, 2024

Hey, i merged this now. New package is available at NPM:
https://www.npmjs.com/package/aframe-orbit-controls-component-2

from aframe-orbit-controls-component.

kfarr avatar kfarr commented on May 24, 2024

Confirming yes this works on A-Frame 0.7.0 and 0.7.1, you can close this ticket

from aframe-orbit-controls-component.

tizzle avatar tizzle commented on May 24, 2024

Thanks for the confirmation, closing the issue now.

from aframe-orbit-controls-component.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.