tivac / xstate-component-tree Goto Github PK

Used here in the codebase:

Removal is here:

statelyai/xstate#2840

Will need to become data.state.children, it sounds like?

Need to not re-run load or prop functions if it's a state that existed in the previous run. Means each instance of ComponentTree needs to track the previous values for each possible state ID and then not re-run them if they're found in the cache.

Hello!

In doing some interesting edge-casery, the meta tag in the component helper is actually stomping on meta data that might already exist on a statenode, the offending line is essentially right here

you can see that there's a raw assignment to node.meta = meta, which causes anything that might previously already exist on that statenode's metadata to be lost.

This is just an issue that was in the back of my mind that I might put a CR up for, but essentially it's as simple as us running an Object.assign for the existing meta with the new metadata that is the loading component..

I'm unsure if we want this to be compatible with other load calls in the statenode meta (if people need to do other asynchronous work), but if we do, we should also augment the load function to include the already existing node.meta.load if there is one.