Shape.light is never used. about pi3d HOT 3 CLOSED

it gets slotted into the unif array so that all the information required by the shaders can get passed with one call of glUniform3fv() I will make a set_light method to go in Shape. I will give it a light number defaulting to 0 to we can use it to set other lights if (when) we get round to adding the functionality to the shaders

from pi3d.

It's true that the light parameter is used in the constructor, but it's
never used after that so there's no point in saving it in Shape.light.

I don't think this is a deal-breaker at all - perhaps we should simply
remove Shape.light, it'd take one second... !

On Thu, Jan 3, 2013 at 6:52 AM, paddywwoof [email protected] wrote:

it gets slotted into the unif array so that all the information required
by the shaders can get passed with one call of glUniform3fv() I will make a
set_light method to go in Shape. I will give it a light number defaulting
to 0 to we can use it to set other lights if (when) we get round to adding
the functionality to the shaders

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/29#issuecomment-11841375.

 /t

http://radio.swirly.com - art music radio 24/7 366/1000

from pi3d.

didn't spot it with quick scan through. Taken it out and put in method

from pi3d.