tinted-theming / base16-builder-node Goto Github PK

Hi all

I'm trying to follow the instructions under Basic Usage - Base16 example for base16-pyradio

A cd ../.. should be added before the last command...

Then

╭─spiros@py ~  
╰─➤  mkdir working_dir && cd working_dir
╭─spiros@py ~/working_dir  
╰─➤  mkdir -p base16/templates && cd base16
╭─spiros@py ~/working_dir/base16  
╰─➤  git clone https://github.com/base16-project/base16-schemes.git schemes
Cloning into 'schemes'...
remote: Enumerating objects: 275, done.
remote: Counting objects: 100% (275/275), done.
remote: Compressing objects: 100% (247/247), done.
remote: Total 275 (delta 35), reused 246 (delta 24), pack-reused 0
Receiving objects: 100% (275/275), 64.29 KiB | 877.00 KiB/s, done.
Resolving deltas: 100% (35/35), done.
╭─spiros@py ~/working_dir/base16  
╰─➤  cd templates
╭─spiros@py ~/working_dir/base16/templates  
╰─➤  git clone https://github.com/edunfelt/base16-pyradio.git
Cloning into 'base16-pyradio'...
remote: Enumerating objects: 1012, done.
remote: Counting objects: 100% (1012/1012), done.
remote: Compressing objects: 100% (78/78), done.
remote: Total 1012 (delta 961), reused 961 (delta 927), pack-reused 0
Receiving objects: 100% (1012/1012), 227.07 KiB | 1.30 MiB/s, done.
Resolving deltas: 100% (961/961), done.
╭─spiros@py ~/working_dir/base16/templates  
╰─➤  cd ../..
╭─spiros@py ~/working_dir  
╰─➤  base16 build base16 --prefix base16-
Parsing scheme definitions...
232 schemes found.
Parsing template definitions...
file:///usr/lib/node_modules/base16-builder-node/lib/template.class.js:82
          if (prefix === undefined) prefix = DEFAULT_PREFIX;
                                    ^

ReferenceError: DEFAULT_PREFIX is not defined
    at file:///usr/lib/node_modules/base16-builder-node/lib/template.class.js:82:37
    at Array.map (<anonymous>)
    at file:///usr/lib/node_modules/base16-builder-node/lib/template.class.js:78:47
    at Array.reduce (<anonymous>)
    at file:///usr/lib/node_modules/base16-builder-node/lib/template.class.js:68:55
    at new Promise (<anonymous>)
    at Function.populate (file:///usr/lib/node_modules/base16-builder-node/lib/template.class.js:60:12)
    at Object.builder.build (file:///usr/lib/node_modules/base16-builder-node/lib/builder.js:15:14)
    at Command.<anonymous> (file:///usr/lib/node_modules/base16-builder-node/lib/app.js:26:23)
    at Command.listener [as _actionHandler] (/usr/lib/node_modules/base16-builder-node/node_modules/commander/lib/command.js:482:17)

base16-builder-node has just been installed with

sudo npm -g base16-builder-node

Am I doing something wrong here?

@richardneililagan I'm willing to take over this project and maintain my fork (I don't expect it to require much effort) if you no longer have time or interest. I did open a PR to bring things up-to-date since 5 years ago. Let me know. I think it would be as simple as updating the Base16 repos to point to the new location.

https://github.com/base16-project/base16-builder-node/blob/master/lib/sources.yaml need to be updated and pointed to the base16-project repos, but those haven't yet been created. @belak what is the plan on doing that? Is it just a matter of creating the repo and bringing across the git history or is there more to it?

@richardneililagan you have write access to this repo but aren't on the http://github.com/base16-project team. Should I add you to the team (as a maintainer) or remove you from the project? I'm not sure if you're aware of base16-project or the changes happening to base16 in general? Additionally, if you'd like to be part of the team and maintain different projects, let me know which ones and I can add you ad a maintainer there.

The current slug library ([email protected]) seems to be too heavy and overarching for the purposes of this library --- it installs and builds unicode definitions. While that is all appreciated and probably sides with caution, using a more straightforward slug library (or maybe even just rolling out our own logic that performs the necessary algorithm) is much more practical.

Could we rename the primary branch to main? It's something all the other repos follow and would be nice if we could make the change here too.

It seems as though forward slashes are being escaped as / in the rendered themes. For example, {{scheme-author}} gets resolved to Jan T. Sott (http://github.com/idleberg) instead of Jan T. Sott (http://github.com/idleberg).

Hi,

I encountered a problem while trying to match theme names generated by the builder to the env variable BASE16_THEME set by base16-shell. As I understand it, base16-shell uses the scheme-slug to set the variable but this does not seem to be how the theme names are generated by this builder. For example, some themes, such as Heetch does not build to base16-heetch.extension but to base16-heetch-dark.extension as seen here.

Is this intentional? Here is the discussion we had in base16-pyradio where this came up, for reference: edunfelt/base16-pyradio#10(comment).

In any case, special characters in the name of some schemes seem to be dropped in the name of the generated theme files such as Rosé Pine which seems to simply build to base16-ros-pine.

From: #9

In any case, special characters in the name of some schemes seem to be dropped in the name of the generated theme files such as Rosé Pine which seems to simply build to base16-ros-pine.

We now build multiple style specs, so we are a universal builder, not a base16 builder.