Giter Club home page Giter Club logo

Comments (5)

Nostrademous avatar Nostrademous commented on June 23, 2024

Also, additionally the requirements.txt could cover all the env variables that must be set to run the code.

STEAM_ID, STEAM_PWD, GOOGLE_APPLICATION_CREDENTIALS, etc

from dotaservice.

lenLRX avatar lenLRX commented on June 23, 2024

if you add all dependency in client.py, the package will be very heavy, since PyTorch is included.
it is good to keep the minimal dependency, since it is 'dotaservice' not 'dotaclient'

from dotaservice.

Nostrademous avatar Nostrademous commented on June 23, 2024

I mean just listing them in a file so you can run ‘pip install -r filename’ and be done rather than rerunning the client numerous times and waiting for exception to be thrown when module not found.

from dotaservice.

lenLRX avatar lenLRX commented on June 23, 2024

separate requirements.txt for client.py is good, but never pollute the requirements.txt for package installation

from dotaservice.

TimZaman avatar TimZaman commented on June 23, 2024

requirements file is ok..
I think the examples should maybe be refactored entirely, it's growing into a lot more than an example. I also want to stay agile and make some friday-afternoon decisions on examples, and I dont want to block you guys. I am not sure how we deal with that.
The dotaservice itself is different: that should just be rocksolid with few api changes.

from dotaservice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.