When you create a migration for the first time it does it correctly. Then if you make changes somewhere and create the migration and update the database, the unmodified tables detect them as new.

Example:
 
Create the model (models.py):

class User (db.Model):
    username = CharField (unique = True)

class Tweet (db.Model):
    user = ForeignKeyField (User, backref = 'tweets')
    timestamp = DateTimeField (default = datetime.datetime.now)

Create the migration (console)
flask-db create app.models
and you get:
INFO: created: 0001_create_table_user
INFO: created: 0002_create_table_tweet

Apply the migration to the DB (console):
flask-db upgrade
and you get
INFO: all migrations applied!

Now, you want to make a change in the model (models.py)

class Tweet (db.Model):
    user = ForeignKeyField (User, backref = 'tweets')
    timestamp = DateTimeField (default = datetime.datetime.now)
    content = TextField ()

Create the new migration
flask-db create app.models
 and you get:
INFO: created: 0003_create_table_user
INFO: created: 0004_create_table_tweet

Apply new migration to the DB:
flask-db upgrade
and get
INFO: upgrade: 0003_create_table_user
ERROR: table "user" already exists

Hi @timster, thank you for your work, I really appreciate it!

We would like to include peewee-moves in our framework but we need a method to fake apply the migration in order to provide an easy way for the users to do the upgrade.

Please let me know what do you think and I would be glad to contribute with this feature.

Thank you!

When trying to create a migration for a nullable ForeignKeyField , null=True does not appear in migration.

Eg:

• model:
  purchase_request = ForeignKeyField(null=True, model=JumpPurchaseRequest, backref='jump_event')

• migration:
  table.foreign_key('AUTO', 'purchase_request_id', on_delete=None, on_update=None, references='jump_purchase_request.id')

Thank you!

Hi!

I'm using peewee-moves without Flask and upon importing the DatabaseManager, I'm getting an error about the missing package, Click at line 907.

Happy to put in a PR to add Click into the requirements.txt, but I wanted to get some feedback from @timster before doing so.

Thanks!

Looks like the peewee.TimestampField isn't handled properly when creating migrations.

Steps to Reproduce:

Model:

from peewee import Model
from peewee import TimestampField
class Data(Model):
    timestamp = TimestampField(utc=True)
    class Meta(object):
        database = db

Resulting migration:

def upgrade(migrator):
    with migrator.create_table('data') as table:
        table.primary_key('id')
        table.timestamp('timestamp')

Correct migration:

peewee.TimestampField gets converted to int for all database backends.

def upgrade(migrator):
    with migrator.create_table('data') as table:
        table.primary_key('id')
        table.int('timestamp')

Resolution

I see you already have the mapping implemented, but either the target is wrong (change to peewee.TimestampField: 'int',) or the target is not created (TableCreator.timestamp).

We've bumped into the same problem that was fixed in #9 but the latest release on PyPI doesn't include the fix. Could you make a new release so that the fix is included?

Thanks for your work. The lib has turned out to be very useful so far.

There are definitely some changes needed. I will try to figure it out this weekend.