Giter Club home page Giter Club logo

apprate's Issues

Reset crash status

What do you think about resetting the PREF_APP_HAS_CRASHED and counters when:

  • ShowIfAppHasCrashed is false
  • user has not pressed yet "Rate" or "Do not show again"
  • the app crashed in a different version than current

NullPointer

HI Timothee,

I am using your AppRate in my application.
But when ever I click on any button on the dialog, I am getting a null pointer at com.tjeannin.apprate.AppRate.onClick(AppRate.java:248).

I even tried your AppRateSample and got the same error.
Can you help me out here?

Regards,
Sunil Sairam.

AppRate on Lollipop

screenshot_2015-04-19-10-19-28 2

The dialog does not appear to be displayed correctly on API V21. As can be seen in the screenshot. This only happens in portrait mode (nexus 5), not in landscape mode.

dismiss

Possible to retrieve a reference to the dialog so that we can dismiss it programmatically.
Example) show the AppRate in onCreate. In onResume check if user has Google Play Services. If user attempts to cancel GooglePlayServices dialog. We finish the activity but get a Window Leak because the AppRate alert dialog is stills showing.

What's the license with the code?

I can't see any licensing details with the AppRate code, either in the docs or in the code itself. Can we use it in a commercial product?

ActivityNotFoundException if no Play Store is installed

03-20 03:19:49.082: E/AndroidRuntime(6156): android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=market://details?id=com.something.myapp}

Problematic line:
hostActivity.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + hostActivity.getPackageName()))); in AppRate.java

Solution: Add try/catch block

Importance: Low (is basically only relevant when testing in an emulator I think)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.