timobrembeck / flagpack-dart-sass Goto Github PK

There is a small issue in the sb flag of the Solomon Islands in which the yellow line is horizontal instead of vertical. I'm sure this is an easy fix, however I am not well versed with svg code and gradients 🤪

Here is the current svg:

And here is the flag according to Wikipedia:

This ticket was first opened the upstream repository (jackiboy/flagpack#7), but since this is no longer maintained and the problem persists on my fork, I copied it into this repository as well.

When using the option $fp-prepend: true; with the default prefix "fp", the medium size fp-md conflicts with the flag for Moldova fp-md. This means, e.g. the following:

<span class="fp fp-de"></span> <span class="fp fp-md fp-de"></span> <span class="fp fp-lg fp-de"></span>

renders to:

And

<span class="fp fp-md"></span> <span class="fp fp-md fp-md"></span> <span class="fp fp-lg fp-md"></span>

renders to:

So I suggest to use either a different suffix for the medium size or set the default prefix to a different value.

Also, a quick workaround for the first problem would be to move "md" to the beginning of the default $fp-countries list so that any other flag classes can overwrite the background-image property since the classes are defined later in the resulting css file.

(I'm aware that it's possible to change the value for $fp-prefix manually, but I still think the default config should make sense.)

I first opened this ticket in the upstream repository (jackiboy/flagpack#14), but since this is no longer maintained and the problem persists on my fork, I copied it into this repository as well.

The flag fa for Farsi which was added in d75418e collides with the class fa used for font awesome.

This causes a few workarounds, e.g. bolt/core@c6390c7

There is a need for a new flag icon which represents German (Easy) in Integreat-CMS to make it easier to distinguish German and German (Easy) by icons. Currenlty the german flag is assinged for both the language.

For the context see the discussion here

"Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0."

The / sign is used in flagpack.scss. Can I just ask; are you planning to address this?