tim-yao / cucumber-nightwatch Goto Github PK

The below command won't fail cucumber tests when it fails.

    // These won't fail
    await this.browser.waitForElementVisible(
      '#not-existing-element',
      1000,
      0,
      true,
      function (result) {
        console.log('result', result)
      }
    )
    await this.browser.waitForElementPresent(
      'css selector',
      '#not-existing-element'
    )
    await this.browser.click('#not-existing-element')
    await this.browser.ensure.elementIsVisible('#not-existing-element')

Below works.

    await this.browser!.expect.element('#not-existing-element').to.be.present;
    await this.browser!.expect.element('#not-existing-element').to.be.visible;
    await this.browser!.assert.visible('#not-existing-element')

The below examples will fail the test step even though abortOnFailure is false.

await this.browser.waitForElementPresent('.not-existing-element', 100, false)
await this.browser.waitForElementPresent({
      selector: '.not-existing-element',
      retryInterval: 1000,
      abortOnFailure: false
    });

This is also related to the bugs in Nightwatch.js programmatic API. I have reported it to the Nightwatch team to look at nightwatchjs/nightwatch#3499

await browser.click('#not-existing-element') won't fail the step.

This is also a Nightwatch programmatic API issue. Maybe nightwatchjs/nightwatch#3499 will fix this.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (@cucumber/pretty-formatter, @tsconfig/node18, eslint, typescript)
• chore(deps): update actions/upload-artifact action to v4
• chore(deps): update dependency eslint to v9
• chore(deps): update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository