ImportError: cannot import name DataFetcher in v2.1.0, wrong tilequeue version in requirements about tileserver HOT 10 CLOSED

Thanks @radumas for posting this fix. I was stuck after following the install guide.

from tileserver.

Instead of having requirements files in each repo though, I think we should have a single set of requirements just in vector-datasource that assumes installation of everything for setup purposes, since that's the useful part practically anyway.

I think that would be useful for people who want the easiest route to setting everything up.

We're releasing a bunch of packages to PyPI now. Would it make sense to use those for released versions, so that we didn't need git versions in requirements.txt? In other words, that we'd specify version constraints in setup.py to avoid things like tileserver referencing DataFetcher without having pulled in a sufficiently new version of tilequeue?

from tileserver.

This would also be an issue if someone followed the current version of the vector-datasource install guide using the checkout versions listed there.

from tileserver.

Yea, good point, those do have master set for those releases. Those instructions are usually tested just with master, and I take the steps you describe above when switching versions. We should probably at a minimum update the documentation to call this out, and ensure that going forward releases have specific versions set in their requirements files.

Instead of having requirements files in each repo though, I think we should have a single set of requirements just in vector-datasource that assumes installation of everything for setup purposes, since that's the useful part practically anyway. We could either split apart just the upstream dependencies from the versions of the tilezen repos, and make separate explicit pip install steps for the install or tilezen repos which might make this more visible. That would also mean that we wouldn't have the problem of having to update the requirements files when we release. Or we just add a step to the instructions that says to edit the bottom of the requirements file for the particular versions desired.

What does everyone think?

from tileserver.

So tilequeue seems to behave happily as a dependency of vector-datasource since AFAIK it doesn't require configuration. Would it be possible to configure vector-datasource's setup (or a version of it) to add tileserver as a git submodule, so that the tileserver config is easily accessible to configure (or otherwise put the tileserver/__init__.py and config.yaml in an accessible location).

Then the instructions to get a "standard install" would be to clone vector-datasource, checkout the latest release, and then run setup.

from tileserver.

I think that would be useful for people who want the easiest route to setting everything up.

Which is where we have the problems anyway right? :)

We're releasing a bunch of packages to PyPI now. Would it make sense to use those for released versions, so that we didn't need git versions in requirements.txt?

We deploy off branches too, so we would need a workflow for that anyway.

from tileserver.

I think PyPi makes even more sense for a simple, stable deployment.

We deploy off branches too, so we would need a workflow for that anyway.

You all can figure out what you need for your development 😉

from tileserver.

I think PyPi makes even more sense for a simple, stable deployment.

Yes, I think this is the best way. I thought it was possible now to pip install tileserver?

from tileserver.

@pnorman Filed related issues this weekend that we're working on. Thanks everyone for the feedback!

from tileserver.

Closing for inactivity.

from tileserver.