thyagoluciano / sm2 Goto Github PK

Hi, your code looks interessant but i can’t figure out how to use it. I can see that it’s written in Dart but i don’t really know this langage.
Can you pls provide some guidance on how to run this github repo?

Thanks

I think the SM-2 algorithm is not implemented correctly here because EF is not calculated on every review. When a q below 3 is given, the EF is not calculated. This means that when q is between 0-2 it has no effect on the EF what so ever, which is not how the algorithm is intended to work.

The algorithm is intended to lower the EF when the user keeps answering incorrectly (q 0-2). In the current code base, the Ease Factor can never go below 2.5 which is the default value.

According to the readme, previousInterval should be an integer, not double.

And there is also a bug in example:

    SmResponse smResponse = sm.calc(
      quality: 0,
      repetitions: 0,
      previousInterval: 2.5,
      previousEaseFactor: 0
    );

default value for previousInterval should be zero, and previousEaseFactor should be 2.5 not zero.

Hello, you wrote a great package, and as I understand it, this is your package pub.dev/packages/sm2
Can you set the correct links in pub.dev? Because at the moment the buttons “Repository (GitHub)” and “View/report problems” refer to github.com/thyagoluciano/flutter_radio