thumbtack / angular-smarty Goto Github PK
View Code? Open in Web Editor NEWAutocomplete UI written with Angular JS.
License: BSD 3-Clause "New" or "Revised" License
Autocomplete UI written with Angular JS.
License: BSD 3-Clause "New" or "Revised" License
I spent a minute with your component and noticed there doesn't appear to be any code to make it accessible to screenreader users. I used it with Voiceover + Safari and it doesn't make any sense.
Rather than list out all of the issues I'll just point you to some resources.
http://www.w3.org/TR/wai-aria-practices/#combobox
http://www.w3.org/TR/wai-aria/roles#combobox
Let me know if I can help with any questions you have, thanks :)
In the demo when I focus the first input and type "a", the list appears, in use my keyboard keys (not the mouse) to select the first result, and press "enter".
It throws an error "[$rootScope:inprog] $digest already in progress" here:
element.bind("blur", function(event) {
if (scope.listItems.length) {
event.preventDefault();
scope.$apply(function() {
scope.close();
})
}
});
It works fine with the mouse click, the error just happens when you use the keyboard arrows to select the result because the key events wrap everything is scope.$apply
as well.
I don't see any tests to accompany this! Any plans to rectify that? :)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.