thoughtbot / tropos-android Goto Github PK

Adding a CHANGELOG would be very beneficial to existing and new contributors since it would give us a quick overview of the state of the project. Plus, it's nice to know what's changed between versions without looking through PRs.

I realize not everyone likes to write CHANGELOGs which is why I recommend github-changelog-generator. It will generate a CHANGELOG from PRs and issues on Github.

It would be great if it was possible to use the app in landscape orientation. The forecast for next 3 days could appear from right side instead of bottom.

I often get stuck not being able to collapse the forecast for next 3 days. What happens is that when I try to scroll down sometimes the app treats the scroll like if I wanted to peek the "Powered by" text. This means that scrolling down doesn't do anything but scrolling up shows the "Powered by" text.

I think that this should be improved by getting rid of the scroll lock and always allow collapsing 3 days forecast, even when the "Powered by" part was getting scrolled too.

I'm trying to understand the code, but this line is confusing:

if (canTargetViewScrollUp() || nestedScrollInProgress) { (line 324 in PullToRefreshLayout)

My understanding is this: PullToRefresh layout takes care of the top overscroll, with the stripe animation. It will go into the when statement in onInterceptTouchEvent in the case that nestedScrollInProgress is false and the target view (RecyclerView) is not at the bottom or the middle (that is, the top). However when I use the app I can drag down on the RecyclerView and it seamlessly transitions into displaying the stripe animation. nestedScrollInProgress is only set to false in onStopNestedScroll. Is onStopNestedScroll called when the RecyclerView hits the top somehow?

Hi,

I just tried to install this in Ireland but was rejected b the Play store.

Is this an oversight?

The app asked for location permissions once (which were granted) and then stayed here. Nexus 6p Android 7.1.1

No data or cache to clear. Reinstalling didn't help.