thoppe / instafilter Goto Github PK

Dear author, what a smart move to approximate Instagram filters using deep learning! I've done this in the past as a PoC myself.
My question is are the models well trained? I went to see the samples but a lot of them looked the same without a before and after comparison. Please enlighten me.

Since TensorFlow uses cuda cores this module isn't compatible with any amd GPU which would of been nice to know in the README. Another thing to note is your code to fix the torch.load() issue has not been updated on pypi. Something else you might want to add on the readme is that if you are on Linux with an amd GPU, amd has developed a tool called ROCm to allow tensorflow to use an amd's GPU cores.

It seems that for devices with only CPU is failing to load the model.
on filtering.py at line 34:
state = torch.load(f_model)
it is required the device parameter
state = torch.load(f_model, map_location=torch.device(device))

Hi
I was wondering if it could be possible, add the parameters of intensity and strength for each filter.

Thanks in advance

Why you user Import Error regarding cv2 instead of using in setup.py the default install of opencv-python