thomhurst / a-sync-redisclient Goto Github PK

View Code? Open in Web Editor NEW

38.0 38.0 9.0 1.19 MB

An asynchronous Redis Client for .NET!

License: Apache License 2.0

C# 99.92% PowerShell 0.08%

a-sync-redisclient's Introduction

Hi there 👋

a-sync-redisclient's People

Contributors

Stargazers

Watchers

Forkers

davidfowl jangocheng falvarez1 matrixdekoder ihehe616 nealhoang

a-sync-redisclient's Issues

Avoid temporary allocations

The message parsing is all string based. While this is convenient it allocates strings to parse the redis command which is then turned into the resulting object. It would be better to parse the ReadOnlySequence directly in each of the result processors.

SocketPipe assigns read pipe and write pipe after kicking off the thread

This is a race condition that may result in a null ref (it happened to me). The fix is simple though.

A-sync-RedisClient/TomLonghurst.RedisClient/Pipes/SocketPipe.cs

Lines 51 to 65 in 068a87f

 if (read) 

 { 

 receivePipeOptions.ReaderScheduler.Schedule( 

 async obj => await ((SocketPipe) obj).CopyFromSocketToReadPipe().ConfigureAwait(false), this); 

 _readPipe = new Pipe(receivePipeOptions); 

 } 

 if (write) 

 { 

 sendPipeOptions.WriterScheduler.Schedule( 

 async obj => await ((SocketPipe) obj).CopyFromWritePipeToSocket().ConfigureAwait(false), this); 

 _writePipe = new Pipe(sendPipeOptions);

High performance parser for the Redis protocol

I happened to be reading this and came across the High performance parser for the Redis protocol
section.

https://redis.io/topics/protocol

It might be interesting to re-work the existing parsing to match this pattern.

thomhurst / a-sync-redisclient Goto Github PK

a-sync-redisclient's Introduction

Hi there 👋

a-sync-redisclient's People

Contributors

Stargazers

Watchers

Forkers

a-sync-redisclient's Issues

Avoid temporary allocations

SocketPipe assigns read pipe and write pipe after kicking off the thread

High performance parser for the Redis protocol

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (read)
	{
	receivePipeOptions.ReaderScheduler.Schedule(
	async obj => await ((SocketPipe) obj).CopyFromSocketToReadPipe().ConfigureAwait(false), this);

	_readPipe = new Pipe(receivePipeOptions);
	}


	if (write)
	{
	sendPipeOptions.WriterScheduler.Schedule(
	async obj => await ((SocketPipe) obj).CopyFromWritePipeToSocket().ConfigureAwait(false), this);

	_writePipe = new Pipe(sendPipeOptions);