thomas-cardon / manaflux Goto Github PK

The app needs a rewrite. It might not work anymore. An assistant that can choose your runes, summoner spells, and item sets for League of Legends.

Home Page: https://ryzzzen.github.io/manaflux/

License: Creative Commons Zero v1.0 Universal

JavaScript 74.43% CSS 9.71% HTML 15.86%

league-of-legends nodejs runes perks itemsets sets items summonerspells automatic shortcuts

manaflux's Introduction

hello 👋

🔭 I'm taking some time for myself at the moment
💬 Ask me about anything
📫 Reach me: @Ryzzzen on Twitter, @Ryzzzen#3455 on Discord
🌟 Pronouns: he/him

NOTE: Top languages does not indicate my skill level, it's a github metric of which languages i have the most code on github

manaflux's People

Contributors

Stargazers

Watchers

Forkers

fernandie isytrus drivers22 vatrak yeethawe smartdigitalmarketplace 106faceeater106 alabalik janerjak

manaflux's Issues

Identifier 'itemset' has already been declared

https://github.com/Ryzzzen/manaflux/blob/33a4a6e7ac5b9c2e24cf03b5b81c529d0261160b/objects/providers/LoLFlavor.js#L29-L32

You might want to change let to var or rename the variable.

Internal error when entering ranked game

Loading Problem

Hi,
The app is stuck in the "LOADING" status on the bottom right, don't know what to do :/

Here is my log:

Loading storage...
ui.js:63 [Localization] Loading value: menu-home
ui.js:63 [Localization] Loading value: menu-settings
ui.js:63 [Localization] Loading value: menu-update
ui.js:63 [Localization] Loading value: button-load-summoner-spells
ui.js:63 [Localization] Loading value: button-load-runes
ui.js:63 [Localization] Loading value: load-automatically
ui.js:63 [Localization] Loading value: summonerspells
ui.js:63 [Localization] Loading value: enable
ui.js:63 [Localization] Loading value: itemsets
ui.js:63 [Localization] Loading value: enable
ui.js:63 [Localization] Loading value: startup
ui.js:63 [Localization] Loading value: startup-windows
ui.js:63 [Localization] Loading value: taskbar
ui.js:63 [Localization] Loading value: champion-select-hide
ui.js:63 [Localization] Loading value: animations
ui.js:63 [Localization] Loading value: enable
ui.js:63 [Localization] Loading value: theme
ui.js:63 [Localization] Loading value: theme-default
ui.js:63 [Localization] Loading value: theme-forest
ui.js:63 [Localization] Loading value: theme-shurima-desert
2ui.js:63 [Localization] Loading value: color-red
ui.js:63 [Localization] Loading value: color-green
ui.js:63 [Localization] Loading value: color-purple
ui.js:63 [Localization] Loading value: color-gray
ui.js:63 [Localization] Loading value: update-available
ui.js:63 [Localization] Loading value: menu-update
ui.js:63 [Localization] Loading value: loading
ui.js:85 Loading value of loadRunesAutomatically to: true
ui.js:85 Loading value of enableSummonerSpells to: true
ui.js:85 Loading value of enableItemSets to: false
ui.js:85 Loading value of auto-start to: true
ui.js:85 Loading value of enableTrayIcon to: false
ui.js:85 Loading value of enableAnimations to: false
ui.js:93 Loading value of theme to: themes/forest-bg.png

2.0 is out: known issues

I just released the new stable release, If you find some issues please let us know here.

Known issues

Manaflux can be launched multiple times
Update button seems to not work in pre-releases/2.0 (Fixed in the next release!)

Error start

Error when starting the program, last version, w10.

v2.0.0 users: update to the 2.0.1 using GitHub

There's an issue with the update module preventing Manaflux from showing it. This release fixes the issues in champion select but also with the update module. You should download the latest release.

Runes editor: pages not updating (Champion Select)

https://youtu.be/ovl58ur9XRg

Can't see runes in champion select, but later it's ok.

Sorry for so many issues but i want to help

I just opened a Discord server here, so we can talk about the app, enhancements and issues faster. It might need enhancements though,
I've added two rooms that are managed automatically by MEE6, one with a GitHub webhook and another with r/leagueoflegends webhook.

It's pretty empty atm

Manaflux loading forever in Linux

Here's the log file:

----------[ Log file level 3 ]----------
Electron v11.1.1
NodeJS v12.18.3
Chrome v87.0.4280.88
----------------------------------------
[Main] [warn] [17:13:43] (electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
[Main] [error] [17:13:43]
(node:20263) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
[Main] [error] [17:13:43]
Error: Error: ENOENT: no such file or directory, open '/home/xeno/manaflux/dev-app-update.yml'
[Main] [error] [17:13:43]
(node:20263) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/xeno/manaflux/dev-app-update.yml'
[Main] [error] [17:13:43]
(node:20263) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
[Main] [error] [17:13:43]
(node:20263) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[Renderer] [warn] [17:13:44] (electron) crashReporter.start is deprecated in the renderer process. Call it from the main process instead.
[Renderer] [error] [17:13:44]
TypeError: Cannot destructure property 'dialog' of 'require(...).remote' as it is undefined.
[Renderer] [error] [17:13:44]
ReferenceError: i18n is not defined
[Renderer] [log] [17:13:44] [Localization] Loading value: ui-menu-home
[Renderer] [warn] [17:13:44] jQuery.Deferred exception: i18n is not defined ReferenceError: i18n is not defined
    at HTMLButtonElement.<anonymous> (file:///home/xeno/manaflux/src/assets/js/ui/i18n.js:4:18)
    at Function.each (file:///home/xeno/manaflux/src/vendor/jquery-3.3.1.min.js:2:2573)
    at w.fn.init.each (file:///home/xeno/manaflux/src/vendor/jquery-3.3.1.min.js:2:1240)
    at HTMLDocument.<anonymous> (file:///home/xeno/manaflux/src/assets/js/ui/i18n.js:2:20)
    at l (file:///home/xeno/manaflux/src/vendor/jquery-3.3.1.min.js:2:29375)
    at c (file:///home/xeno/manaflux/src/vendor/jquery-3.3.1.min.js:2:29677) 
[Renderer] [error] [17:13:44]
ReferenceError: i18n is not defined

Some relevant info:
OS: EndeavourOS Linux x86_64
Kernel: 5.9.14-arch1-1
CPU: Intel i7-6700K (8) @ 4.200GHz
GPU: NVIDIA GeForce GTX 980
DE: Plasma 5.20.4

In order to install manaflux I cloned the repo and cd-ed into it using git clone https://github.com/Ryzzzen/manaflux.git && cd manaflux followed by npm install && electron .

No aram builds

Can't seem to get the aram item build
Try using 2.4.5/2.4.2/2.4.1

Tried:
-Reset the app
-Empty the cache
-Reset the settings

Always leaves me with a oracle pot
Been happening since 2.4.1

Newest release of Manaflux (11/22/18) won't work due to antivirus.

Anti virus is seeing an intrusion attempt by ws023.coinhive.com and blocks it and thus manaflux doesn't work.

Is this actually an attack or is this an overprotective anti virus?

Please add U.GG

Please add support for U.GG

Translation support

Better support for translation after choosing a champion ?

App intercepts all ctrl + shift + i key inputs

Could you make it so when the app is hidden it doesn't intercept this key input? Or even better if the window is not focused. I cannot use this key input to open the dev tools in my browser when the app is running

Ordering of website ignored?

I choose OP.GG as my top and main site to load runes from, it always load from LOG1

Downloading takes ages

I've updated yesterday and since then, downloading takes ages. 40 seconds aren't enough sometimes even though I'm on a 250 MBit/s connection. What's happening?

UI: replace navigation arrows by dots

Advanced settings are now hidden until you find these two little arrows at the top left corner.
It may be better to use dots like these:

In my opinion, it becomes a little more obvious that there are additional settings here.

Build a github page

It would be easier for users to interact with the software since not everyone is familiarized with Github.

Error

C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request-promise-core\lib\errors.js:14 Uncaught (in promise) RequestErrorcause: Error: connect ECONNREFUSED 127.0.0.1:50363
at Object._errnoException (util.js:1024:11)
at _exceptionWithHostPort (util.js:1046:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)error: Error: connect ECONNREFUSED 127.0.0.1:50363
at Object._errnoException (util.js:1024:11)
at _exceptionWithHostPort (util.js:1046:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)message: "Error: connect ECONNREFUSED 127.0.0.1:50363"name: "RequestError"options: {uri: "https://riot:[email protected]:50363/lol-game-data/assets/v1/summoner-spells.json", transform: undefined, simple: true, resolveWithFullResponse: false, callback: ƒ, …}response: undefinedstack: "RequestError: Error: connect ECONNREFUSED 127.0.0.1:50363↵ at new RequestError (C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request-promise-core\lib\errors.js:14:15)↵ at Request.plumbing.callback (C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request-promise-core\lib\plumbing.js:87:29)↵ at Request.RP$callback [as _callback] (C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request-promise-core\lib\plumbing.js:46:31)↵ at self.callback (C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request\request.js:185:22)↵ at emitOne (events.js:116:13)↵ at Request.emit (events.js:211:7)↵ at Request.onRequestError (C:\Users\Matheus\AppData\Local\Programs\manaflux\resources\app.asar\node_modules\request\request.js:877:8)↵ at emitOne (events.js:116:13)↵ at ClientRequest.emit (events.js:211:7)↵ at TLSSocket.socketErrorListener (_http_client.js:387:9)"proto: Error

Internal error when entering ARAM

Hi guys, I just downloaded the app. I haven't been able to make it run at all.

Logs:

[Renderer] [log] [20:12:48] [ChampionSelectHandler] Entering
[Renderer] [log] [20:12:48] [ChampionSelectHandler] Entering into ARAM
[Renderer] [log] [20:12:49] [ChampionSelectHandler] Champion changed to: Cassiopeia
[Renderer] [log] [20:12:49] [ProviderHandler] Downloading data for Cassiopeia
[Renderer] [log] [20:12:49] [ProviderHandler] Using providers:  LoLFlavor
[Renderer] [log] [20:12:49] [ProviderHandler] Using LoLFlavor
[Renderer] [log] [20:12:49] [GameAssetsProxy] https://riot:[email protected]:62507/lol-game-data/assets/v1/champion-icons/69.png
[Renderer] [log] [20:12:50] [ProviderHandler] Couldn't aggregate data.
[Renderer] [error] [20:12:50]
TypeError: Cannot read property '2' of undefined
[Renderer] [error] [20:12:50]
The gathered data is empty. This is an error that shouldn't happen. Manaflux can't recover from it. You should restart the app.
[Renderer] [log] [20:13:02] Flu.x >> Upload error
[Renderer] [error] [20:13:02]
StatusCodeError: 503 - "<!DOCTYPE html>\n\t<html>\n\t  <head>\n\t\t<meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n\t\t<meta charset=\"utf-8\">\n\t\t<title>Application Error</title>\n\t\t<style media=\"screen\">\n\t\t  html,body,iframe {\n\t\t\tmargin: 0;\n\t\t\tpadding: 0;\n\t\t  }\n\t\t  html,body {\n\t\t\theight: 100%;\n\t\t\toverflow: hidden;\n\t\t  }\n\t\t  iframe {\n\t\t\twidth: 100%;\n\t\t\theight: 100%;\n\t\t\tborder: 0;\n\t\t  }\n\t\t</style>\n\t  </head>\n\t  <body>\n\t\t<iframe src=\"//www.herokucdn.com/error-pages/application-error.html\"></iframe>\n\t  </body>\n\t</html>"
[Renderer] [log] [20:13:02] [DataValidator] Copying required properties for Flu.x
[Renderer] [dir] [20:13:02]
{"roles":{"JUNGLE":{"perks":[{"suffixName":"(HW%)","selectedPerkIds":[8465,8463,8473,8453,8321,8347,5007,5003,5002],"primaryStyleId":8400,"subStyleId":8300,"provider":"championgg"},{"suffixName":"(MF)","selectedPerkIds":[8465,8463,8473,8453,8321,8347,5007,5003,5001],"primaryStyleId":8400,"subStyleId":8300,"provider":"championgg"},{"selectedPerkIds":[8214,8224,8210,8232,8321,8347,5008,5008,5001],"primaryStyleId":8200,"subStyleId":8300,"provider":"opgg"},{"selectedPerkIds":[8214,8224,8210,8232,8321,8347,5008,5008,5001],"primaryStyleId":8200,"subStyleId":8300,"provider":"opgg"}],"summonerspells":[],"itemsets":[{"title":"CGG1 Ivern > Jungle","type":"custom","map":"any","mode":"any","blocks":[{"type":"Starter (Most Frequent) | 51.65% WR","_type":{"i18n":"providers-cgg-blocks-starters-mf","arguments":["51.65%"]},"recMath":false,"items":[{"id":"1039","count":1},{"id":"2031","count":1}]},{"type":"Starter (HW%) | 52.31% WR","_type":{"i18n":"providers-cgg-blocks-starters-hw%","arguments":["52.31%"]},"recMath":false,"items":[{"id":"1039","count":1},{"id":"2003","count":1},{"id":"2055","count":1}]},{"type":"Trinkets","_type":{"i18n":"item-sets-block-trinkets"},"recMath":false,"items":[{"id":"2055","count":1},{"id":"3340","count":1},{"id":"3341","count":1},{"id":"3348","count":1},{"id":"3363","count":1}]},{"type":"Completed build (Most Frequent) | 45.38% WR","_type":{"i18n":"providers-cgg-blocks-completed-build-mf","arguments":["45.38%"]},"recMath":false,"items":[{"id":"3107","count":1},{"id":"3109","count":1},{"id":"3117","count":1},{"id":"3174","count":1},{"id":"3190","count":1},{"id":"3504","count":1}]},{"type":"Completed build (HW%) | 50.00% WR","_type":{"i18n":"providers-cgg-blocks-completed-build-hw%","arguments":["50.00%"]},"recMath":false,"items":[{"id":"3107","count":1},{"id":"3109","count":1},{"id":"3117","count":1},{"id":"3174","count":1},{"id":"3190","count":1},{"id":"3504","count":1}]},{"type":"Consumables | Skill Order: Q => W => E","_type":{"i18n":"item-sets-block-consumables-skill-order","arguments":["Q => W => E"]},"recMath":false,"items":[{"id":"2003","count":1},{"id":"2138","count":1},{"id":"2139","count":1},{"id":"2140","count":1}]}],"priority":true,"provider":"championgg"},{"title":"OPG1 Ivern > Jungle","type":"custom","map":"any","mode":"any","blocks":[{"type":"Starter 1 | Skill Order: E => Q => W","_type":{"i18n":"item-sets-block-starter-skill-order-numbered","arguments":[1,"E => Q => W"]},"recMath":false,"items":[{"id":"1039","count":1},{"id":"2031","count":1}]},{"type":"Starter 2 | Skill Order: E => Q => W","_type":{"i18n":"item-sets-block-starter-skill-order-numbered","arguments":[2,"E => Q => W"]},"recMath":false,"items":[{"id":"1039","count":1},{"id":"2003","count":1},{"id":"2055","count":1}]},{"type":"Trinkets","_type":{"i18n":"item-sets-block-trinkets"},"recMath":false,"items":[{"id":"2055","count":1},{"id":"3340","count":1},{"id":"3341","count":1},{"id":"3348","count":1},{"id":"3363","count":1}]},{"type":"Recommanded Items","_type":{"i18n":"item-sets-block-recommanded"},"recMath":false,"items":[{"id":"3107","count":1},{"id":"3174","count":1},{"id":"3504","count":1}]},{"type":"Boots (choose one)","_type":{"i18n":"item-sets-block-boots"},"recMath":false,"items":[{"id":"3111","count":1},{"id":"3117","count":1},{"id":"3158","count":1}]},{"type":"Consumables","_type":{"i18n":"item-sets-block-consumables"},"recMath":false,"items":[{"id":"2003","count":1},{"id":"2138","count":1},{"id":"2139","count":1},{"id":"2140","count":1}]}],"priority":true,"provider":"opgg"}],"gameMode":"CLASSIC"}},"championId":427,"gameVersion":"9.5","gameRegion":"la1","version":"2.4.2"}
[Renderer] [log] [20:13:02] Flu.x >> Upload

Stuck at loading?

Ryzzzne pls
EUW btw

Preseason issues

Preseason came, and broke Manaflux with it as expected. Here's what I found for now.

Fixed

Fixed login issues
Fixed Champion.GG
Fixed OP.GG

Known issues

Update design issues: version text is black, button flickers FIXED!
League of Graphs: adds duplicate runes and makes the page invalid

Our new process in Manaflux can now prevent providers from sending invalid runes to League, because Manaflux will now make sure that everything is valid, so that's not a big deal for now.

Manaflux crashes if you have the wait for champion to be locked feature enabled FIXED!
Manaflux crashes if you enter in ARAM FIXED!
Other providers: new perks may be missing
Data Validator: adding new perks automatically when they're missing doesn't work FIXED!

Came out with the 2.1.7

Data Validator is going to be a lot smarter: RELEASED!
It can now detect if runes are at the wrong place and replace it by a generic one
It can now add the new runes if needed

Overall, those changes should prevent Manaflux from giving invalid rune pages to League.

Languages need to be updated

Hello everyone, I have just merged the rework branch into the master branch, since we're pretty close to a stable release. However if someone has time, all languages need to be updated (except english).

Languages that need an update

German (DE)

Languages added

Italian (IT) - Thanks @LorisSecuro
Russian (RU) - Thanks @iSytrus

Languages updated

Portuguese brazilian (PT-BR) - Thanks @recs182
Polish (PL) - Thanks @kko7
Spanish (ES) - Thanks @rogama25
French (FR)

Note: It might be easier to just copy&paste the english file and then edit the values, since I also changed, added and removed a lot of keys.

@kko7 gave me this software, called i18n-manager, that might help you.

The languages folder is here.

UI not loading

That's what's happening right after installation.

Windows 10

Providers

Hello,
Would it be possible to add KoreanBuilds and Probuilds as providers? One more thing: what about downloading the builds to league folder (champions)? Sometimes ManaFlux wont find builds during champ select and the option the download the builds previously takes too long.

Rune page creation

Would it be possible to place the runes into a specified page? IE. I have a rune page that is designated for changing runes often. For champions with multiple suggested pages, you could prompt the user which one they'd like to use on the ManaFlux UI.

Stuck at loading

Currently just getting stuck on this screen. I'm updated to the latest version.

Found this on another thread just thought I'd throw in

If you need more info from me let me know.

Rune Page is not Updating

I Installed the App and its working but it won't change my Runes in Champ Select.

Manaflux is unusable now

Ever since the update for preseason and the addition of the mining feature to help support you the product has become unusable and couldn't serve its actual purpose of providing rune pages. I just had to remove everything from manaflux. The rune pages stopped loading and updating etc.

It also became a security risk. Even windows thought it was one.

Stuck at loading

Hi. Sorry for bad english.
The program is completely stuck at launch. The buttons do nothing, and i need to manually terminate it through Task Manager.
My client's language/region is RU if its matter.
Can you please take a look? Thank you.

Error after new commit

commit

Add more providers

Hello! For now there's not a lot of providers for Manaflux to work properly I think, do you have any ideas of websites I should add?

For now I thought of:

U.GG (For now it has been implemented, but it's not working as it requires Manaflux to render the website to show the data)
Lolalytics (Same reason as U.GG, but I've asked them on Reddit if they could make an endpoint for us like Championify, I hope they will)

ManaFlux doesn't load after "Path found"

Hello, the program found my league path and I thought that it would work now. Still when I join the champ select and pick a champion, it wont show the icon / runes etc and act like it isn't connected to my client.