thomai / gossip-python Goto Github PK

Hey, trying to integrate this into a blockchain project and the configuration file convention is a bit clunky. Ideally there should be a search path set of directories that the application looks through and if it finds none it creates a template in the user space while giving an appropriate warning to the user in the logs.

I plan on addressing this via PR and intend to keep backwards compatibility with config/config.ini convention as well as cross platform support between POSIX and Windows systems.

In the test_short_to_bytes function should add:
print("test_short_to_bytes")
at the beginning and
print(" PASSED")
to the end of the function

Similarly for test_bytes_to_short():
add
print("test_bytes_to_short")
and
print(" PASSED")
to the end.

Finally at the end of the file we should have:
if name == "main":
test_bytes_to_short()
test_short_to_bytes()

In examples/connections_simulation.py line 170, 171 when running the example it appears that there are errors:
ERROR:root:dict_keys(['192.168.1.21:1', '192.168.1.27:1', '192.168.1.29:1'])
ERROR:root:192.168.1.2:1
ERROR:root:dict_keys(['192.168.1.3:1', '192.168.1.6:1', '192.168.1.7:1', '192.168.1.11:1'])
ERROR:root:192.168.1.3:1

Looking at the code it has:
logging.error(client.get_ident())
logging.error(client.get_connection_idents())

If this is just working as designed should it be something like:
logging.info(client.get_ident())
logging.info(client.get_connection_idents())