thm-mni-ii / tals Goto Github PK

Display all schedules trough a calendar so the students know when they need to attend to a course.

The Moodle plugin does not support the export of CSV values with umlauts.

Use the Moodle coding style to format the php code.

• The selectors are not unique. This can cause problems with other plugins.
• Constant definitions are also not unique.

It seems that either of the following capabilities:

• mod/tals:manage
• mod/tals:change
• mod/tals:viewreports

is enough to perform many operations, including deletions or updates.

But for example, the mod/tals:viewreports is declared as read-only and the name does not suggest that it grants access to modifying the TALS status.

It would be great if a student could enter the pin trough the Moodle plugin too.

The IOS App does not accept passwords that contain a "+".

Accordingly to Moodle Plugin Types the claimed naming convention states the prefix "block_" for Block-Plugins instead of "mod_" which is reserved for activity modules.

So, the correct name should be "moodle-block_tals" instead of "moodle-mod_block".

The Moodle plugin does not display the network the student has used to connect to Moodle os that the could enter the pin.

Attempting to add a new appointment on PostgreSQL throws error:

Debug info: ERROR: syntax error at or near "end"
LINE 1: INSERT INTO mdl_tals_appointment (title,start,end,descriptio...
^
INSERT INTO mdl_tals_appointment (title,start,end,description,courseid,groupid,fk_type_appointment_id,fk_pin_id) VALUES($1,$2,$3,$4,$5,$6,$7,$8) RETURNING id
[array (
'title' => '...',
'start' => 1528896600,
'end' => 1528901400,
'description' => '',
'courseid' => 2,
'groupid' => 1,
'fk_type_appointment_id' => 1,
'fk_pin_id' => 1,
)]
Error code: dmlwriteexception
Stack trace:

    line 482 of /lib/dml/moodle_database.php: dml_write_exception thrown
    line 250 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
    line 904 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
    line 960 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->insert_record_raw()
    line 322 of /mod/tals/locallib.php: call to pgsql_native_moodle_database->insert_record()
    line 345 of /mod/tals/locallib.php: call to tals_insert_appointment()
    line 147 of /mod/tals/addappointment.php: call to tals_update_appointment()

I suppose the reason might be that "END" is a reserved keyword on PostgreSQL.

What is the point of the tals_pin table? From what I can see, there is kind of 1:1 relationship with the tals_appointment table. So why not to have PIN-related columns directly in that table?

Just curious.

Swiping down to refresh the course list does only work if you do a "long" swipe.

Any student (i.e. user with the 'mod/tals:view' capability) can use the URL like profile.php?id=...&student=... and view others' attendance logging. I would expect that such access should be privileged for higher capabilities only.

I guess it has been duplicated by mistake.

It seems that scripts like delete.php or token.php are meant to be AJAX scripts.

https://docs.moodle.org/dev/AJAX_pre_2.9#Writing_server-side_AJAX
https://docs.moodle.org/dev/AJAX

We have the web app, the mobile apps, the documentation and the plugin inside one repo. We could separate them for a cleaner repository.

Visiting token.php throws

Exception - Call to undefined function external_generate_token_for_current_user()

Error code: generalexceptionmessage
Stack trace:

    line 72 of /mod/tals/locallib.php: Error thrown
    line 38 of /mod/tals/token.php: call to tals_get_token()

Given that you expect to have a single instance per course, I was wondering if the activity module is best plugin type for this feature. It seems that maybe a block for example could be more appropriate?

We have

• code,
• comments,
• documentation
• and even git comments
  that are written in German.

We should at least rewrite the first three to English.

In the documentation it is described how to add a block for the attendance system to a cource.
This block is used to enable the pin and enter a pin for an appointment.

The block is not present in this repository! There is currently no way for a student to enter a pin on the website or the course master to start the pin for the current appointment via block (still possible via appointment list)

The view Is written using plain html outputs.
The style does not fit into Moodle.

The query

"SELECT COUNT(DISTINCT groupid) FROM mdl_tals_appointment WHERE fk_pin_id IS NOT NULL AND courseid = ?",

must not have the mdl_ prefix hard-coded. Moodle sites can have their own prefixes: