thibtrip / thib Goto Github PK

Some feedback about the class splitting, as requested 😄

This reaching through objects is considered a bit of an anti-pattern in some circles (Law of Demeter). The reasoning goes something like this: Say you change the signature of Legs.move to have a required required argument, like an integer steps. Then you would have to change all the code which uses human.legs.move. Instead you could hide the legs as implementation detail and only have to change the one place inside the facade.

class Human():
    ...
    def move_legs(self):
        self._legs.move(3)

Here you are assigning a global variable, why would you need to do that? If you want to use it as global then you can just import it? I would pass a singleton as parameter to __init__, since there might be humans which do not belong to the same community 😄.

If avoidable I would not construct objects in __init__ but rather inject the dependencies.

Maybe something like this?

class Brain():
    def __init__(arms, legs, ...):
         self._arms = arms
         self._legs = legs
   def move_legs():
         self._legs.move()
    ...

class Human():
    def __init__(brain):
        self._brain = brain
    def move_legs(self):
        self._brain.move_legs()