theupshot / 4thdownbot-model Goto Github PK

The model behind @NYT4thDownBot

License: MIT License

Python 71.66% JavaScript 28.34%

4thdownbot-model's Issues

'week' column not in armchair analysis schema (should be 'wk')

This is the same as issue #2, it now shows up in the data preparation for the final possession probability in data_prep.py line 376.

Bug: Week Column does not correspond with Armchair Analysis Schema

In data_prep.py the query which limits the data to the first 17 weeks does so using the column name "week", the data that is provided by ArmchairAnalysis uses the column name "wk". See the schema here:

http://armchairanalysis.com/2015_NFL_Table_Schema.pdf

do you want fourthdowncalculator.com?

Hi,
A few years ago I bought fourthdowncalculator.com and put a website up there, because Brian Burke's website wasn't mobile friendly. My efforts were very soon outshadowed by your model and the resources of the NYT.

Do you want the domain? Happy to do what I can to support NFL numeracy!

Bot.py relies on nonexistant data

Bot.py relies on the file fgs_grouped_nyt.csv (line 14)
data['fgs'] = pd.read_csv('data/fgs_grouped_nyt.csv')

However, data_prep only creates fgs_grouped.csv, this doesn't appear to simply be a naming issue since winprob.expected_wp_fg expects dome_rate or open_rate columns not present in fgs_grouped.

This seems to come from data_prep.nyt_fg_model() not being implemented

Recommend Projects