thethingsnetwork / lorawan-webhook-templates Goto Github PK

Summary

In my-template.yaml I have:

paths:
  uplink-message: /uplink-message
  join-accept: /join-accept
  location-solved: /location-solved

But when the webhook is added, only the uplink-message endpoint was added:

Environment

• Webhook template: new under development
• The Things Stack version: v3.11.2

Steps to Reproduce

1. Create a template that adds more than just the uplink-message enpoints.
2. Create a webhook from the tempalte.
3. Look at which endpoints are active.

What do you see now?

Only uplink-message is added.

What do you want to see instead?

All defined endpoints in the template should be added.

How do you propose to implement this?

Fix the bug.

Can you do this yourself and submit a Pull Request?

No

Summary

The readme states:

When submitting a new Webhook template or making changes to an existing one, please make sure the integration defined by it works correctly.

What is the recommended method to test a new webhook?

Is the intention that one should install a private Things Stack instance, load the templates, and test in that way?

How do you propose to implement this?

Document how to test a webhook.

Can you do this yourself and submit a Pull Request?

Updating the readme yes, but I need the required information first.

Summary

Add a webhook template to forward gps tracker data to TTN Mapper.

Why do we need this?

Map coverage of TTNv3, and possibly also private instances.

Environment

The Things Stack v3.10.5 and v3.11.0-rc1

How do you propose to implement this?

Write a template that contains all the relevant info.

Can you do this yourself and submit a Pull Request?

Yes, but there are some data that is required to identify the network, which is currently not available in the webhook. See TheThingsNetwork/lorawan-stack#3705

Cloud Studio asked to change their logo. They sent it to me by email, @adriansmares can we host it somewhere to be linked in the template?

Summary

I have a default value defined in the template:

fields:
  - id: experiment
    name: Experiment Name (optional)
    description: If you are testing (new device, balloon flights, etc) and do not want your data to appear on the main map, please specify an experiment name.
    secret: false
    default-value: "test"

But on the console the field is not filled in with the default value:

Environment

• Webhook template: new
• The Things Stack version: v3.11.1

Steps to Reproduce

1. Add a field to the webhook template
2. Add a default value
3. Reload console / restart stack

What do you see now?

Field is not pre-filled with default value

What do you want to see instead?

The field should be pre-filled with the default value

How do you propose to implement this?

Fix the bug

Can you do this yourself and submit a Pull Request?

No

Summary

TTN Mapper does not need to send downlink messages. It however needs to know the TTS Domain, ie the cluster ID. The only way to determine this at the moment is by adding create-downlink-api-key so that the downlink URLs are added to the headers.

TTS has an issue open to add a x-tts-domain header which will always provide the originating cluster id: TheThingsNetwork/lorawan-stack#3795

As soon as TheThingsNetwork/lorawan-stack#3795 is fixed, we can remove create-downlink-api-key from the TTN Mapper webhook template.

Environment

• Webhook template: TTN Mapper
• The Things Stack version: all

Steps to Reproduce

n/a

What do you see now?

A downlink api key is created when the TTN Mapper webhook is created using the template.

What do you want to see instead?

TTN Mapper should not require a downlink api key as it will and should never send downlinks.

How do you propose to implement this?

It's an easy fix as soon as TheThingsNetwork/lorawan-stack#3795 is implemented.

Can you do this yourself and submit a Pull Request?

Yes

Summary

We need a better workflow for when pull requests are created.

What is already there? What do you see now?

#26 went unnoticed for over a week. While we do have a GitHub Actions workflow for adding the triage label to new issues, we don't have a workflow for adding it to pull requests. Since the CODEOWNERS file doesn't set any reviewers, we also don't automatically request review for pull requests.

What is missing? What do you want to see?

Some workflow to request triage or review of pull requests.

How do you propose to implement this?

Either:

• a GitHub action that adds the triage label (do we even check PRs with that label?)

or

• set the @TheThingsNetwork/integration-maintainers team as code-owner of this repository.

Summary

Webhook template for thethings.IO Webhook integration.

Can you do this yourself and submit a Pull Request?

Yes

Summary

Webhook template for Qubitro Webhook integration

Can you do this yourself and submit a Pull Request?

Yes

Summary

I want to make a template field optional. But a red asterisk is added to the right of the field name.

And when I try to save while leaving it empty

Environment

• Webhook template: new under development
• The Things Stack version: v3.11.1

Steps to Reproduce

1. Create a webhook template with one field and load the template.

What do you see now?

The field is required.

What do you want to see instead?

Allow leaving the field blank.

How do you propose to implement this?

Add an optional property to the field definition.

Can you do this yourself and submit a Pull Request?

No

Summary

We'd like to add an integration for our IoT platform Wonderland which focuses on tracking applications.

Why do we need this?

This will expand the potential use of both our and your platform and TheThingsNetwork

Environment

We're mostly using PHP for connectivity integrations, sometimes Python. In this case we'll use PHP with Slim

How do you propose to implement this?

We already implemented TTN support for both V2 and V3 stacks. The only thing missing is an easy-to-use integration template for our users. Implementation will likely be a no-brainer as all the JSON decoding etc. is already in place.

Can you do this yourself and submit a Pull Request?

We're using GitLab on our end, but I guess things will be just as easy with GitHub

Summary

From what I can see the TTS console uses the order of tamplates in templates.yml as the draw order.

Ordering these templates alphabetically will be more fair, and more user friendly.

- ubidots
- datacake
- tago
- akenza
- thingspeak
- qubitro
- thethingsio

Environment

• Webhook template: enter
• The Things Stack version: v3.11.3

Steps to Reproduce

NA

What do you see now?

The templates are listed in the order in which they were added.

What do you want to see instead?

Order the templates alphabetically.

How do you propose to implement this?

• Manually re-order the templates.yml file
• Change The Things Stack's code to ignore the order in templates.yml and always order alphabetically.

Can you do this yourself and submit a Pull Request?

Yes, but this requires a discussion.

The current actions make use of deprecated features and should be updated.
This relates to the use of:

• Node.js 12
• set-output
• save-state