thery / coqprime Goto Github PK

@thery In N/ChineseRem.v there are several definitions and theorems about the betafunction, which are imported by the module PRrepresentable of Goedel project https://github.com/coq-community/hydra-battles/blob/master/theories/goedel/PRrepresentable.v .
But this function is not explicitely named. Would it be possible to add to N/ChineseRem.v a definition of beta , for readability's sake ?

Please note that there are a few variants (number or order of arguments) in the litterature, but it's easy to convert from one variant to another.

The Coq team released Coq 8.19.0 on January 24th, 2024.
The corresponding Coq Platform release 2024.01 should be released before April 30th, 2024.
It can be delayed in case of difficulties until May 15th, 2024, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.19.0.

Coq Platform CI is currently testing opam package coq-coqprime-generator.1.1.1
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime-generator/coq-coqprime-generator.1.1.1/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2024.01, please inform us as soon as possible and before March 31st, 2024!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.19~2024.01+beta1 which already supports Coq version 8.19.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#405

While packaging for Debian, the packaging tools complained I was going to distribute binaries without manual pages, so I wrote some:
firsprimes.txt
o2v.txt
pocklington.txt
(those should be renamed from .txt to .1 -- github wants .txt)

The Coq team released Coq 8.19.0 on January 24th, 2024.
The corresponding Coq Platform release 2024.01 should be released before April 30th, 2024.
It can be delayed in case of difficulties until May 15th, 2024, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.19.0.

Coq Platform CI is currently testing opam package coq-coqprime.1.4.0
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime/coq-coqprime.1.4.0/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2024.01, please inform us as soon as possible and before March 31st, 2024!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.19~2024.01+beta1 which already supports Coq version 8.19.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#405

Many of the examples contain Open Local Scope. I am not sure since when, but this does not compile any more. It should now be Local Open Scope.

6130c70 broke compatibility with Coq 8.7.2. Because this repo ships the makefile generated by Coq 8.8, which is not rebuilt if I'm using a different version of Coq, coqdep does not emit anything, and so there's no dependency ordering, and so make breaks if I pass it -j.

Thanks for the excellent library. The github page lacks references, so it might be worthwhile to add a link to this page.

The Coq team released Coq 8.18.0 on September 7th, 2023.
The corresponding Coq Platform release 2023.10 should be released before November 30th, 2023.
It can be delayed in case of difficulties until January 15th, 2023, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.18.0.

Coq Platform CI is currently testing opam package coq-coqprime.1.3.0
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime/coq-coqprime.1.3.0/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2023.10, please inform us as soon as possible and before October 31st, 2023!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.18+beta1 which already supports Coq version 8.18.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#372

opam install coq-coqprime on 8.13 fails with

File "./src/Coqprime/Z/ZCmisc.v", line 31, characters 0-95:
Error: This command does not support this attribute: export.
[unsupported-attributes,parsing]

8.12 has the same issue

Under Coq.8.8.1:

File "./src/Coqprime/num/Bits.v", line 16, characters 0-26:
Error:
Found no subterm matching "Z.pos (Pos.succ ?M1339)" in the current goal.

make[1]: *** [Makefile:656: src/Coqprime/num/Bits.vo] Error 1
make[1]: *** Waiting for unfinished jobs....
File "./src/Coqprime/Z/Ppow.v", line 29, characters 0-4:
Error: Attempt to save an incomplete proof (in proof Ppow_correct)

     = 1740564225 :: 343969132 :: 6812243 :: nil
     : number
     = 0 :: 1 :: nil
     : number
File "./src/Coqprime/num/montgomery.v", line 50, characters 0-31:
Warning: wB is declared as a local definition [local-declaration,scope]
     = 31415926535897932384626433%Z
     : Z
make[1]: *** [Makefile:656: src/Coqprime/Z/Ppow.vo] Error 1
File "./src/Coqprime/Z/ZCmisc.v", line 67, characters 0-4:
Error: Attempt to save an incomplete proof (in proof Pminus_mask_spec)

make[1]: *** [Makefile:656: src/Coqprime/Z/ZCmisc.vo] Error 1
File "./src/Coqprime/Z/ZCAux.v", line 75, characters 0-4:
Error: Attempt to save an incomplete proof (in proof prime_induction)

make[1]: *** [Makefile:656: src/Coqprime/Z/ZCAux.vo] Error 1
File "./src/Coqprime/num/montgomery.v", line 199, characters 0-45:
Error: Found no subterm matching "phi (i + j)" in the current goal.

make[1]: *** [Makefile:656: src/Coqprime/num/montgomery.vo] Error 1
make: *** [Makefile:318: all] Error 2

Reverting the last commit solve the issue.

The Coq team released Coq 8.18.0 on September 7th, 2023.
The corresponding Coq Platform release 2023.10 should be released before November 30th, 2023.
It can be delayed in case of difficulties until January 15th, 2023, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.18.0.

Coq Platform CI is currently testing opam package coq-coqprime-generator.1.1.1
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime-generator/coq-coqprime-generator.1.1.1/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2023.10, please inform us as soon as possible and before October 31st, 2023!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.18+beta1 which already supports Coq version 8.18.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#372

The Coq team released Coq 8.17+rc1 on December 29th, 2022 and plans to release Coq 8.17.0 around March 7th, 2023.
The corresponding Coq Platform release 2023.03 should be released before April 14th, 2023.
It can be delayed in case of difficulties until June 30, 2023, but this should be an exception.

This issue is to inform you that to our (possibly a few days old) best knowledge the latest released version of your project (1.2.0) does not work with Coq 8.17+rc1.
We tried to remove version restrictions in opam files and possibly make or configure files, but this did not suffice.

Please note that in Coq Platform CI (unlike Coq CI) we test only released / tagged versions. Coq CI is currently testing commit 762c7f5 on repository https://github.com/thery/coqprime - which likely means that this commit does work in Coq CI.

Could you please create a tag and opam package, or communicate us any existing tag that works with Coq branch v8.17, preferably before March 21st, 2023?
In case we might have to delay the Coq Platform release cause of issues with your project, we would prefer to be informed about the situation as early as possible.

In case the tag and opam package are available before March 21st, 2023, it will be included in an early Coq Platform beta release of the for Coq 8.17+rc1.

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.17~2023.03+preview1 which already supports Coq version 8.17+rc1 and contains already working (possibly patched / commit pinned) Coq Platform packages.

Please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#335

The Coq team released Coq 8.16+rc1 on June 01, 2022.
The corresponding Coq Platform release 2022.09 should be released before September 15, 2022.
It can be delayed in case of difficulties until October 15, 2022, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.16+rc1.

Coq Platform CI is currently testing opam package coq-coqprime.1.2.0
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime/coq-coqprime.1.2.0/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2022.09, please inform us as soon as possible and before August 31, 2022!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.16+rc1~2022.09~preview1 which already supports Coq version 8.16+rc1 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#274

I saw two typos in gencertif/README:

--- coqprime.orig/gencertif/README
+++ coqprime/gencertif/README
@@ -12,7 +12,7 @@
             digits (in base 10).
         * -proth k n : generate certificate for the Proth number : k*2^n + 1.
         * -lucas n : generate certificate for the Mersenne number 2^n - 1
-            using Lucas test (more efficiant).
+            using Lucas test (more efficient).
         * -mersenne n : generate certificate for the Mersenne number 2^n - 1
             using Pocklington,
         * -dec file : generate certificate for the number given in file,
@@ -25,7 +25,7 @@
 options are:
        -split : generate one file per certificate
         -o file : set the output in file "file"
-       -o name : set the name of the final theorem "name"
+       -n name : set the name of the final theorem "name"
 
 BUILD / INSTALL :

opam/opam lists the license as MIT. LICENSE contains LGPL. I am fine using and contributing under either, but clarifying this probably wouldn't hurt.

@thery : I have a bit of a hard time to get the ceritifcate generator compiled on all OS platforms Coq Platform supports. I hope I fixed everything meanwhile, but there is one thing which is hard to fix: the use of the function "pipe" in pocklington.c. Under MinGW (Windows) such a function does not exist. One can emulate it to a certain extent in various ways, but I wonder if this is required or if you can find a way to write the code which doesn't use "pipe".

Hi,

fiat-crypto depends on coqprime for number theory lemmas (and potentially for actual primality proofs in the future). Currently, we bundle an out-of-date version of coqprime at https://github.com/mit-plv/fiat-crypto/tree/master/coqprime, which mostly works for us. However, this arrangement is causing the Coq developers a fair amount of headache, e.g. mit-plv/fiat-crypto#269 and mit-plv/fiat-crypto#316. We would like to change fiat-crypto to include coqprime as a git submodule in the fiat-crypto COQPATH. We already do this for bbv (mit-plv/fiat-crypto@e11d6d0), and cross-crypto does this for fcf.

This would require rearranging the coqprime directory structure such that List would become src/Coqprime/List, where src is just any directory that only contains Coq files and Coqprime determines the form of Require Import Coqprime.PrimalityTest. This would probably require changes in Make and etc. Would a change like this be acceptable to coqprime? I am willing to volunteer to work on this, though I am not sure I understand the coqprime build situation well enough to be certain that I don't break anything, so I probably wouldn't get everything right on the first try.

Thanks,
Andres

The Coq team released Coq 8.15.0 on January 13, 2022.
The corresponding Coq Platform release 2022.02 should be released before February 28, 2022.
It can be delayed in case of difficulties until April 11, 2022, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.15.0.

Coq Platform CI is currently testing opam package coq-coqprime.1.1.1
from platform patch repository https://github.com/coq/platform/tree/main/opam/opam-coq-archive/released/packages/coq-coqprime/coq-coqprime.1.1.1/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2022.02, please inform us as soon as possible and before February 14, 2022!

The working branch of Coq Platform, which already supports Coq version 8.15.0, can be found here https://github.com/coq/platform/tree/main.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#193

The Coq team released Coq 8.17+rc1 on December 29th, 2022 and plans to release Coq 8.17.0 around March 7th, 2023.
The corresponding Coq Platform release 2023.03 should be released before April 14th, 2023.
It can be delayed in case of difficulties until June 30, 2023, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.17+rc1.

Coq Platform CI is currently testing opam package coq-coqprime-generator.1.1.1
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime-generator/coq-coqprime-generator.1.1.1/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2023.03, please inform us as soon as possible and before March 21st, 2023!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.17~2023.03+preview1 which already supports Coq version 8.17+rc1 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#335

The Coq team released Coq 8.14+rc1 on September 17, 2021 and plans to release Coq 8.14.0 before October 31, 2021.
The corresponding Coq Platform release 2021.11 should be released before November 30, 2021.
It can be delayed in case of difficulties until January 31, 2022, but this should be an exception.

This issue is to inform you that to our (possibly a few days old) best knoweldege the latest released version of your project (1.0.6) does not work with Coq 8.14+rc1.
We tried to remove version restrictions in opam files and possibly make or configure files, but this did not suffice.

Please note that in Coq Platform CI (unlike Coq CI) we test only released / tagged versions. Coq CI is currently testing commit d4bcfa8 on repository https://github.com/thery/coqprime - which likely means that this commit does work in Coq CI.

Could you please create a tag, or communicate us any existing tag that works with Coq branch v8.14, preferably before November 15, 2021?
In case we might have to delay the Coq Platform release cause of issues with your project, we would prefer to be informed about the situation as early as possible.

The working branch of Coq Platform, which already supports Coq version 8.14+rc1, can be found here https://github.com/coq/platform/tree/main.

Please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#139

In firstprime.c, the minimum can't be lower than 1, which means 2 is out of scope, since its index is 0.

The fix is as simple as:

--- coqprime.orig/gencertif/firstprimes.c
+++ coqprime/gencertif/firstprimes.c
@@ -11204,7 +11204,7 @@
     max = atoi(argv[2]);
   } else exit (1);
 
-  if (min < 1) min = 1;
+  if (min < 0) min = 0;
   if (max > MAXSIZE) max = MAXSIZE;
 
   out = fopen(filename,"w+");

According to the readme and old documentation, coqprime should support checking eliptic curve certificates generated by Primo. However I cannot seem to get o2v working with certificates generated by Primo. Is there a step-by-step guide on this somewhere, or what is the status of this support?

If you are too lazy to install the Coq system, or have no spare cpu-time, you can put your prime number in an issue, we will do the job for you.

hello I would like to know if 7 is prime

There's a .travis.yml file, but the Travis CI tests don't seem to run; Travis has become somewhat more hostile to open-source users (see, e.g., this blog post), so it probably makes sense to port .travis.yml to GitHub Actions.