Giter Club home page Giter Club logo

flarum-ext-gifs's Introduction

flarum-ext-gifs's People

Contributors

clarkwinkelmann avatar deltarager avatar dependabot[bot] avatar flarum-bot avatar imorland avatar ralkage avatar sacchinbhg avatar therealsujitk avatar tolgaaaltas avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

flarum-ext-gifs's Issues

Support for Flarum 1.0

This is an awesome plugin but not currently compatible. Would love to have this work with v1.0.2.

Thanks!

Use default values when settings aren't in the database

Flarum only saves settings in the database that have been changed, hence the default values aren't saved in the database. When settings aren't saved in the database, a default value needs to be used in the oninit() function. For example

this.engine = app.forum.attribute(`${prefix}.engine`);

needs to be changed to

this.engine = app.forum.attribute(`${prefix}.engine`) || 'giphy';

Temporary Fix

Simply change the setting in the admin panel to a different value and save it so that Flarum understands a change has been made and needs to be updated. You can change it back to it's previous value and save it again.

Typo in ListGIFController

The ListGIFController.php file has a typo in the class name.

class ListGifController extends AbstractListController { ... }

should be changed to

class ListGIFController extends AbstractListController { ... }

JS files compiled in development mode instead of production

Hey there ๐Ÿ‘‹

Just recently ran Clark's migrate to Flarum scanner on my forum and from the results, it looks as if the JS for your extension is still compiled for dev mode.

image

Would you be able to fix that? I really like using this extension :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.