therealmjp / shadows Goto Github PK

This is more of a question than an issue. I noticed in the columns test scene that if the camera and light directions are at a sufficient enough angle, the shadows of columns at the far end of the scene take on the shape of concentric rings (see image below).

I'm guessing this is due to ambiguity between sample positions on the cascade shadow map from the camera's current perspective, but I was curious if you've seen this before and if there is a reason behind the concentric rings shape.

Remaining app settings:

View from above:

)

Hello!
This might be a dumb question but i cannot figure out how to get this to run outside of VS. When i run Shadows.exe i get this error.

It runs fine when debugging inside visual studio. I also tried putting the AntWeakBar64.dll in the same folder as the exe. I gets past that error but just crashes.

Any help is appreciated, and thanks!

In SampleShadowCascade in Mesh.hlsl, when computing the shadow position of the receiving pixel, I believe you should be applying the cascade scale first, then adding the offset.

    shadowPosition += CascadeOffsets[cascadeIdx].xyz;
    shadowPosition *= CascadeScales[cascadeIdx].xyz;

should be

shadowPosition *= CascadeScales[cascadeIdx].xyz;
shadowPosition += CascadeOffsets[cascadeIdx].xyz;

Purely mathematically speaking, if we think of applying this as a matrix, the latter is the proper order. Of course, depending on the values, these can produce drastically different results. But perhaps in this particular sample's use-case, the difference is not noticeable. Most other samples (like the DX SDK CascadedShadowMap sample) apply these in scale then offset order.