thepython10110 / exchangeclone Goto Github PK

Is your feature request related to a problem? Please describe.
I can't use the constructor/destructor with hoppers.

Describe the solution you'd like
add support for the hopper mod

Describe alternatives you've considered
I tried using the pipeworks mod, it doesn't work either.

https://github.com/minetest-mods/hopper/blob/master/api.txt

Describe the bug
right-click digging full-grown amethyst cluster with a red matter hammer crashes.

Expected behavior
digs as normal.

Game
Mineclone 2

Reproduction Steps
start new creative-mode world with Mineclone 2 and ExchangeClone.
give yourself a red matter hammer and a full-grown amethyst cluster (mcl_amethyst:amethyst_cluster)
place amethyst cluster
right-click with red matter hammer
observe crash

Additional context

2024-01-25 00:16:43: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'exchangeclone' in callback item_OnPlace(): /app/share/minetest/builtin/game/item.lua:88: attempt to call method 'find' (a nil value)
2024-01-25 00:16:43: ERROR[Main]: stack traceback:
2024-01-25 00:16:43: ERROR[Main]: 	/app/share/minetest/builtin/game/item.lua:88: in function 'get_node_drops'
2024-01-25 00:16:43: ERROR[Main]: 	...t/.minetest/mods/exchangeclone/exchangeclone/hammers.lua:23: in function 'action'
2024-01-25 00:16:43: ERROR[Main]: 	...etest/mods/exchangeclone/zzzz_exchangeclone_init/lib.lua:595: in function 'node_radius_action'
2024-01-25 00:16:43: ERROR[Main]: 	...t/.minetest/mods/exchangeclone/exchangeclone/hammers.lua:68: in function <...t/.minetest/mods/exchangeclone/exchangeclone/hammers.lua:37>

Describe the bug
A clear and concise description of what the bug is.

Some strange debug code gets outputted by the server

Expected behavior
A clear and concise description of what you expected to happen.

nothing to show up

Game (e.g. Minetest Game)
Which game were you playing?
Mineclonia 0.91.0
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
steps to reproduce

Start a new world with exchangeclone enabled
Don't have any armor
and Fall from a distance

ModError: Failed to load and run script from /home/owner/Applications/minetest-5.7.0-stable/bin/../mods/exchangeclone/init.lua:
...ble/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:121: attempt to index field 'descriptions' (a nil value)
stack traceback:
...ble/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:121: in function 'register_set'
...inetest-5.7.0-stable/bin/../mods/exchangeclone/armor.lua:91: in main chunk
[C]: in function 'dofile'
...minetest-5.7.0-stable/bin/../mods/exchangeclone/init.lua:21: in main chunk
Check debug.txt for details.

Is your feature request related to a problem? Please describe.
Many mods add new kinds of crafting recipes, exchangeclone doesn't support them since it doesn't know about the new kinds of crafting.

Describe the solution you'd like
Almost all mods that add new kinds of crafting tell Unified Inventory about all their crafting recipes, it would be useful for ExchangeClone to automatically support all those crafting recipes by relying on Unified Inventory's list of crafting recipes when Unified Inventory is enabled.

Describe the bug
Create a new world in creative mode with Minetest Game, anvil, mobs_water, and toolranks.
Give yourself a red matter sword.
Spawn a turtle using a turtle spawn egg.
punch the turtle with the sword -- observe that the sword is now damaged -- this is a bug.
place an anvil.
right click the anvil with the damaged sword.
right click the anvil with nothing in your hand.
observe that you now have two red matter swords -- this is a more serious bug.

Expected behavior
red matter swords can't be damaged. damaged red matter swords can't be duplicated.

Game (e.g. Minetest Game)
Minetest Game.

Is your feature request related to a problem? Please describe.
When using the Gem of Eternal Density, I sometimes mine things I haven't learned yet, I want to be able to learn them without them being converted to energy before I have a chance.

Describe the solution you'd like
The Gem of Eternal Density automatically causes the player to learn all items it converts.

Describe alternatives you've considered

• Have the Gem of Eternal Density not convert items until you've learned them.
• Don't use the Gem of Eternal Density

I think supporting Exile would be awesome, some of the crafting ingredients will need to change, e.g. lava is basically unobtainable due to heat damage, and iron is basically the only traditional ore that exists. otoh chests in the abandoned city underground is a great place for random ExchangeClone items to appear instead of or in addition to having crafting recipes, such as the philosophers stone. It appears as though you can use megamorph.register_loot for that.

Is your feature request related to a problem? Please describe.
I find that when playing games with ExchangeClone, once you get enough energy to buy a Tome of Everything, you have near-creative mode which effectively removes all need to explore or craft anything to get new materials you haven't seen before, removing a major aspect of what makes the game interesting.

Describe the solution you'd like
give the option to disallow the Tome of Everything to avoid the above problem. this could be a privilege for on servers where admins could have a Tome of Everything as a less-cheating substitute for the give privilege, it could also be a server setting to disable it server-wide.

Describe alternatives you've considered
pretending it doesn't exist...

Describe the bug
A clear and concise description of what the bug is.

AsyncErr: Lua: Runtime error from mod 'mcl_potions' in callback item_OnPlace(): ...bin/../games/mineclonia/mods/ITEMS/mcl_beehives/init.lua:10: attempt to index local 'player' (a nil value)
stack traceback:
...bin/../games/mineclonia/mods/ITEMS/mcl_beehives/init.lua:10: in function 'old_honey_harvest'
...ames/minetest-5.7.0/bin/../mods/exchangeclone/shears.lua:259: in function 'on_rightclick'
.../bin/../games/mineclonia/mods/ITEMS/mcl_potions/init.lua:60: in function <.../bin/../games/mineclonia/mods/ITEMS/mcl_potions/init.lua:52>

Expected behavior
A clear and concise description of what you expected to happen.

not to crash

Game (e.g. Minetest Game)
Which game were you playing?

mineclonia 0.91.0

Screenshots
If applicable, add screenshots to help explain your problem.

N/A

Additional context
Add any other context about the problem here.

try to harvest honey with exchangeclone enabled

Describe the bug
tin, silver, and mithril ingots do not have an energy value

Expected behavior
energy values to be assigned

Game (e.g. Minetest Game)
mineclone2 with moreores mod

Describe the bug
When converting a diamond pick back to energy, if it's slightly worn it can give a huge amount of energy back (20,135,936 when I tested it), which is waay more than a new diamond pick costs (24,580).

Expected behavior
worn diamond picks to not give more energy back than they originally cost.

Game (e.g. Minetest Game)
Minetest Game 5.8.0

Describe the bug
typing a ; in the transmutation table search box causes the search box to disappear and the client to give the error "invalid field element..."

Expected behavior
searching for semicolons to work

Game (e.g. Minetest Game)
Minetest Game

this looks like you forgot a minetest.formspec_escape call

Describe the bug
Enabling technic_worldgen from mt-mods causes energy values for most ingot types to not be set.

Expected behavior
iron, gold, tin, etc. ingots have energy values

Game (e.g. Minetest Game)
Minetest Game 5.8.0

Additional context
exchangeclone is at commit d5c153e
technic is at commit mt-mods/technic@f1b9928

reproduction steps:

• install technic from https://github.com/mt-mods/technic at commit f1b99282e889e9a483c76af95ee3370b6d2b2d04
• create new world based on minetest game 5.8.0
• enable exchangeclone dev modpack
• enable technic_worldgen from technic_mc_compat (editing world.mt might be easiest)
• run game
• look up ingots, observe that iron ingot has no energy value.

2024-07-28 01:05:28: WARNING[Main]: Undeclared global variable "default" accessed at ...t-5.8.0/bin/../mods/exchangeclone/exchangeclone/init.lua:9
2024-07-28 01:05:28: ERROR[Main]: ModError: Failed to load and run script from /home/owner/Downloads/minetest-5.8.0/bin/../mods/exchangeclone/exchangeclone/init.lua:
2024-07-28 01:05:28: ERROR[Main]: .../bin/../mods/exchangeclone/exchangeclone/constructor.lua:133: attempt to index field 'sound_mod' (a nil value)
2024-07-28 01:05:28: ERROR[Main]: stack traceback:
2024-07-28 01:05:28: ERROR[Main]: .../bin/../mods/exchangeclone/exchangeclone/constructor.lua:133: in main chunk
2024-07-28 01:05:28: ERROR[Main]: [C]: in function 'dofile'
2024-07-28 01:05:28: ERROR[Main]: ...t-5.8.0/bin/../mods/exchangeclone/exchangeclone/init.lua:153: in main chunk
2024-07-28 01:05:28: ERROR[Main]: Check debug.txt for details.
2024-07-28 01:05:28: ACTION[Main]: Server: Shutting down
2024-07-28 01:05:28: ERROR[Main]: Invalid line in /home/owner/Downloads/minetest-5.8.0/mods/exchangeclone/settingtypes.txt " Keep unnecessary temporary data (such as the list of recipes) after load time for debugging purposes."
2024-07-28 01:05:28: ERROR[Main]: Invalid line in /home/owner/Downloads/minetest-5.8.0/mods/spawncraft/settingtypes.txt "<<<<<<< HEAD"

I've noticed that in Mineclonia, the dark oak logs are showing an energy level of zero. I'm unsure if this is intended behavior or a bug, so I wanted to bring it to your attention for further investigation.

Describe the bug
Using dreambuilder_hotbar and other similar mods, you can set the hotbar to any size you please. Gem of Eternal Density has hardcoded values instead of using player:hud_get_hotbar_itemcount()

Expected behavior
use player:hud_get_hotbar_itemcount() to get the correct hotbar size.

Game (e.g. Minetest Game)
Minetest Game

Describe the bug
A Gold Nugget randomly has a waay too large energy value (16,384). A Gold Ingot's energy value isn't affected.
I've also seen this happen with Iron Nuggets (though, for iron, not yet in the latest version, so that may be fixed), and with Carbon Steel.

Expected behavior
Gold Nuggets have 1/9th the energy of Gold Ingots.

Game (e.g. Minetest Game)
MineClone2 with latest versions of Technic Plus Beta and ExchangeClone.

Screenshots
Bad Gold Nugget energy:

Bad Carbon Steel energy:

Additional context
Previous discussion

Is your feature request related to a problem? Please describe.
I can't use the constructor/destructor with any pipeworks tubes

Describe the solution you'd like
add support for pipeworks

Describe alternatives you've considered
I tried using the hopper mod, it doesn't work either.

https://github.com/mt-mods/pipeworks/wiki/api.md#tube-definition-in-node-definition

Describe the bug
mt-mods/technic just added MineClone2 support, ExchangeClone doesn't give energy values to items from technic when playing with MineClone2.

Expected behavior
Technic things such as Chromium Ingot have an energy value.

Game (e.g. Minetest Game)
MineClone2 0.86.2

Reproduction Steps
Get latest Git version of https://github.com/mt-mods/technic (not yet on ContentDB as of writing)
Create world with MineClone2.
Enable pipeworks, basic_materials, and the exchangeclone modpack.
Enable technic_worldgen and technic mods (the whole modpack doesn't work yet last I checked, just those two mods, which are enough to use it)
Start game
Get some chromium/uranium/sulfur/etc., cook into ingots where applicable.
Observe that they don't have any energy values.