theodinproject / theodinproject Goto Github PK
View Code? Open in Web Editor NEWMain Website for The Odin Project
Home Page: http://www.theodinproject.com
License: MIT License
Main Website for The Odin Project
Home Page: http://www.theodinproject.com
License: MIT License
Hi guys,
I have attempted to improve the contacts controller. Please review.
Ref: #111
The index method on this controller currently has some code smells and is pretty messy. We should refactor it to make it more maintainable
https://github.com/TheOdinProject/theodinproject/blob/master/app/controllers/sitemap_controller.rb
Likely some sloppy javascript after the Swiftype installation. Prevents the Facebook button from loading.
<%= form_for @user do |f| %>
...
<% 3.times do %>
<%= fields_for @user.shipping_address.build do |addy_form| %>
...
<% addy_form.text_field :zip_code %>
...
<% end %>
<% end %>
<%= f.submit %>
<% end %>
should have these minor changes
<%= f.fields_for @user.shipping_address.build do |addy_form| %>
...
<%= addy_form.text_field :zip_code %>
Also notice the letter C is missing from Course List in the hierarchy within the drop down menu at the top. It seems to be moved off of the visible page area towards the left.
From page: http://www.theodinproject.com/ruby-on-rails/advanced-forms
"This project is currently down. Please use Ngrok. It is hoped Localtunnel and Ngrok will eventually be merged._"
With Rails 5 being officially released we should upgrade, thankfully we are already running Rails 4.2 and Ruby 2.3 so the upgrade process should be relatively straight forward.
http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0
Notes
Because rails 5 supports left outer joins out of the box we should change the by_latest_completion
method on the user model.
There are currently no unit tests for this controller which is having a negative impact on our test coverage. We should create some standard tests for this controller.
We are moving over to gitter because of the message limitations on slack. To facilitate this the following changes need to be made:
The new gitter chat: https://gitter.im/TheOdinProject/theodinproject
This helper currently has a few long methods which could use some refactoring. This also needs a unit test.
https://github.com/TheOdinProject/theodinproject/blob/master/app/helpers/application_helper.rb
Hey, when trying to log in to the Odin project on mobile I found that the Github sign in link takes up the whole page and the alternate sign in box is inaccessible. I am using chrome on a galaxy s5 running Android 5.0.
There are a couple of edge cases with this feature that need to be covered in the acceptance tests:
This helper currently has a very long messy method, this could use some cleaning up. It also needs a unit test.
https://github.com/TheOdinProject/theodinproject/blob/master/app/helpers/bootstrap_flash_helper.rb
Clicking the "Tweet" button at the bottom of lessons currently auto-populates the tweet with a really lame description and doesn't include the link to the lesson!. Ideally, pull together a more interesting blurb (including @TheOdinProject and/or a useful hashtag like #learntocode ) and definitely include the link to the lesson. Just be sure to leave room (e.g. 20 chars) at the end so people can retweet.
I am just trying to understand how this whole thing works. if I understand correctly, the main data exists in curriculum repo and using that seeds.rb
is generated. And this will be used to load the initial data.
but...how this seeds.rb
is generated and gets updated as curriculum gets updated?
Via email:
Just a heads up, the websites login page isnt working from an android cell phone. The only option available, is to login with my github account, but it isnt linked yet. Its trying to have me make a new account for the odin project, or login, but it then loops me back to the same login with github page.
These files currently have a lot over unused code from the last rails upgrade. They need to be cleaned up and simplified.
The first extra credit link is down on this page.
Thanks!
Problem via email with changing email address. The error he mentions is a standard we're sorry but something went wrong
. Hopefully there is enough here to try and reproduce the issue!
It sounds like this occurs when someone:
This has not been attempted for reproduction yet, I'm just filing the issue. Original email below. Can provide redacted info if necessary and appropriate.
My question is I sign in with GitHub and I changed my address on GitHub, but the address change doesn’t appear in my TOP user info. I am going to be shutting down the old email address ([redacted]) so I am changing any online profiles with this address.
When I try updating my user info on TOP it doesn’t change. When I attempt to change I get the below error message.
It’s not a huge deal because I am able to log in with GitHub. If nothing else I thought you’d like to know about the error.
BTW - this is my second run at sharpening up my coding skills and TOP is great! Thank you! I am tracking 1,000 hours of coding education online while I am working full-time and saving up money for a bootcamp and The Odin Project is making it easy to stay on track.
Regards,
[redacted]
I signed in using my Github account however my account was not confirmed, so I selected "Didn't receive instructions or need them again?", entered my email ID with which I have my github account but I did not get any email regarding confirmation.
These will be tests for lesson show page,
Important The tests for this controller should be done before working on this ticket #200
The suggestion action currently has a few code smells, it should be refactored to make it more maintainable.
These tests will be for the lesson index page,
It seems like the disqus widget provided throughout the site links to the user's Odin account. While this is all fine and dandy for some, I do have a disqus account and would like the option to log into it. I have no clue if this is feasible from Odin's end, but it would be helpful.
Can I get added to the slack channel?
There's one link missing in getting_involved.md, at line 39.
1. Watch this [video intro to SCRUM].
This helper currently has one method which has a lot of code smells, refactoring it will make it more maintainable. The unit test may need some work too.
https://github.com/TheOdinProject/theodinproject/blob/master/app/helpers/admin_flash_helper.rb
I believe this is around the Facebook login features we're using and is hopefully just a quick one.
Hi Erik,
The Odin Project has been making recent API calls to Graph API v2.0, which will reach the end of the 2-year deprecation window on Monday, August 8, 2016. Please migrate all calls to v2.1 or higher in order to avoid potential broken experiences.
We recommend using our new Graph API Upgrade Tool to see which of your calls are affected by this change as well as any replacement calls in newer versions. You can also use our changelog to see the full list of changes.
You can view this and other Developer Notifications related to your app, The Odin Project, in the App Dashboard.
Thanks,
The Facebook Team
As a new contributor to the site, it may be nice to have an easy-to-follow set up guide. It's especially confusing how to connect curriculum data, Git API key to make rake curriculum:update_content
work.
This =>
Updating the curriculum...
Creating Github link...
Cycling through 0 lessons...
ALL DONE! Updated the curriculum.
Both application.yml and curriculum.rake were updated by with GitHub API Key...
Several emails recently like: "I forgot my password and when I attempt to recover it, it keeps saying something went wrong." Seems to have happened after the bundle update
on the repo's gems, so something there is probably the issue. Tests don't seem to be covering it since the suite was all green on the relaunch.
Step one of refactoring the code base is setting up some measurement tools to help us assess our progress.
This came via the form on the bottom of the site. Think it's a problem? We've had some complaints before about the mobile-unfriendliness of our navbar and headers.
New feedback suggestion for The Odin Project!
User < not logged in > was on /home and said:
pls, fix the size of "div .headline h1" for mobiles using css3. media screen (max width 768px) { font-size:18px }
In Web Development 101/ The Front End/ HTML & CSS basics the links for OverAPI's HTML Cheat Sheet & OverAPI's CSS Cheat Sheet are broken. They take you to overapi.com/css/ and overapi.com/html/. If you remove the final back slash from each link they work.
The content of the page is not properly getting displayed in Chrome Browser regardless of logged in or not. The content gets displayed for a fraction of second and hides. The version of the browser is '38.0.2125.122'. AdBlocker is disabled. When inspected with dev tools, I can seen that a 'display: none' is added to the div with class 'row' inside the div with class 'container'.
This helper currently has some messy long and messy methods, they are in need of some refactoring. This also needs more unit tests.
https://github.com/TheOdinProject/theodinproject/blob/master/app/helpers/lessons_helper.rb
This helper currently has some large and messy methods, they need to be refactored. This also needs unit tests added.
https://github.com/TheOdinProject/theodinproject/blob/master/app/helpers/users_helper.rb
Current behavior: After a certain amount of time, users who created their accounts through GitHub are blocked from logging in, with a message "You have to confirm your account before continuing."
Screenshot:
Desired behavior: Omniauth should be sufficient confirmation by itself, so these users should never be required to confirm their email addresses separately.
I think I can fix sometime this week.
On the page
http://www.theodinproject.com/javascript-and-jquery/javascript-basics
the "Javascript 101 from learn.jquery.com" link is dead.
Looks like if you're on a specific lesson page and click the "resend confirmation email" link (or whatever it's called) it 404's because it tries to generate the /confirm_email link gets appended to the course name, e.g. http://theodinproject.com/ruby-on-rails/confirm_email
and there's a routing error.
Following the standard setup directions (step 5) yields
-bash: bundle: command not found
Bundler is available in all other directories on my system. Any thoughts?
We have a env
sample file with the keys to test all in development and test environment.
About it, could be able to have environment variables for development and testing for services. So if everyone who can contribute not need to create these variables of the services, e.g. disqus
, github
, sendgrid
...
From email noon PT 5/31/16:
Hello,
I came across a problem when trying to confirm my email from the welcome email. It directs me to the correct link but times out with the error notification in the subject line. I had to add "www." to get it working.
If you call something like this GET /users/show/12321313
i.e. non existent user id. You will get this error in production server We're sorry, but something went wrong.
Clearly there is an issue.
Upon further investigation it comes down to redirect_to :back
in users controller. There is no referrer url i.e. request.env["HTTP_REFERER"]
returns nil so the above line of code raises an exception. To solve this we could use session["previous_url"]
or we could catch the exception and just return them to root url. I think the former is better.
Finally as I go over the code should I just keep one issue open and keep adding to that one or just make seperate ones as I have done here?
Currently, this controller does not have any unit tests, which is negatively impacting our test coverage. We should create some standard controller tests for this.
This looks like it was removed in 2013.
When I visit the homepage I have to navigate to the courses page then click the course I'm currently doing and then click on the lesson. It would be convenient to have some sort of resume progress link on the homepage so I could just go directly there. Could potentially store the last visited lesson in a cookie or maybe use the successor to the last completed lesson.
It has been noted by a few users that the chat button looks like an advert, coming up with a new design for it that makes it look less like a call to action button would be great.
We should also think about implementing a small lesson that tasks the user with signing up to the chat.
The rake tasks in lib/curriculum.rake
will pull content from https://github.com/TheOdinProject/curriculum even when the content does not change.
You can test this simply by running two consecutive rake curriculum:update_content
logically the second call should not update any content because the content has not changed.
I am sure this bug is simple but I am too dumb to figure this out XD
As a learner
To keep track of my progress
I want to mark a lesson complete
I noticed that the Discus comments associated with the lessons are not displayed when navigating by the bubble nav bar, ( .lc-progress-wrapper ). If I look back at the previous lesson by clicking the bubble nav bar, , and return to the original page by clicking the nav bar again, all comments will be gone. I found the comment will load again by navigating from the main nav page, or altering the url to remove the referer link.
http://www.theodinproject.com/ruby-programming/ruby-on-the-web?ref=lc-pb
to
http://www.theodinproject.com/ruby-programming/ruby-on-the-web?
Thanks so much for the site!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.