theoblt / dotsearch Goto Github PK

What's up?

Searching for an exact search key doesn't populate that search inside the search suggestions.
So let's say you have define the following shortcuts:

• z
• zd
• zendesk

When you search for z, suggestions now only include:

zd
zendesk

Or when you search for zd, suggestions only include:

zendesk

Why is it worth fixing?

When you've searched your shortcut zd, *you want to be sure what it will point to * when you press Enter - if you don't see it in the suggestions, you don't know where you're going to end up. That hurts discovery and adoption of the extension. It feels "broken" - to me it's the one thing that makes you feel that first version is unfinished.

How to investigate

Some ideas 💡

• Find another way to suggest the currently searched term, for example, leveraging temporarily the setDefaultSuggestion method (doc here). This looks like it worked really well for another user (StackOverflow)
• Dig into how Chrome's suggest function works ( doc here )
• Look for other Chrome extensions leveraging the Chrome's Omnibox API, in order to figure out how they manage to suggest the currently typed search term.
• Try and understand further how the "

Description
We currently have an issue while searching for a result.

The following error is prompted in console:
Error in event handler: Error: error on line 1 at column 250: EntityRef: expecting ';'

This is due to a description format which may have a breaking symbol.

How to reproduce
Simply search after typing . + Tab press in chrome search bar

Note that after typing many letters, the error does not appear to be triggered again, when the search result does not match the breaking description.

Detection process
The description issue consideration came after replacing all description assignment in map loop by a simple description = 'ok'

Next steps
We'll need to detect which description break suggest process and either shoot or fix it.

Possible solution
Preventing users to add new key in DotSearch® is not an option.
In order to prevent such breaking behaviour in the future, we'll need to find a solution.

We may want to filter descriptions before assignment in order to serialise breaking symbols.