theneosloth / bolas Goto Github PK

How to replicate:
!diff
Diff too long

Here's a suggested improvement. Instead of Diff too long have this output in an embed.

  url 1 title          url 2 title
29 Creatures     30 Creatures     
31 Lands         30 Lands
18 Sorceries     20 Sorceries
22 Instants      20 Instants
Which would you like to see?

!diff creature

<list the creature differences>

I'm trying to pull the art of some online only promos, such as this one

I've tried artist tag, promo tag, and is:promo such as
!art [[stasis a:seb]]
which pulls a very different art.

If any one card fails to be found, no card results are returned, as opposed to info for found cards and an error for an unfound card (preferably with the card name).

The code is extremely inefficient right now. For example: in order to keep the track of the last card found the bot currently stores a full card object for every server it's connected to instead of just saving the name of the last card used.

This command fails
!diff https://tappedout.net/mtg-decks/rad-farm/ https://tappedout.net/mtg-decks/razaketh-adnaus-scepter\

My guess is a split card somewhere?

If my card search results are as follows
Card 1 {1}
Card 2 {1}
Card 3 {1}
Card 4 {1}
Card 5 {1}

When the !price command is executed only the following is displayed:
9.99 -- Card 1

It would be nice if it displayed all the card prices. Maybe like so:
9.99 -- Card 1
29.07 -- Card 2
5.99 -- Card 3
0.50 -- Card 4
0.99 -- Card 5

Hi again theneosloth

I hope you're doing well. We in the EDH discord still love your bot with all its great functionalities haha. :)

There seems to be an issue with the price functionality when it comes to MDFC cards (or probably multi faced cards in general). When searching for a MDFC card like "Needleverge Pathway" it returns "Price not found.". The same is true when searching for "Needleverge Pathway // Pillarverge Pathway", the way the API treats the name of double faced cards.

When looking through the code, I think this issue stems from two parts. Both in the "search_card" function that is called by the price function.

1. One seems to be that the search function finds the name "Needleverge Pathway", but it's a "card_face" and so it returns a not found.
2. The other seems to be for how the function parses the query to create a URL. The urllib.parse.quote function uses the '/' as a safe character as default, so I think what happens here is that the '//' in the middle is not parsed the way the API expects it, so it also can't find it as a card.

My proposal would be to find a way to return a card in the first way of searching for the DFC, and for the second situation (especially if the first can't be solved), the quote function has a second variable where you define the safe character, which you could set to something not used in the API.

Kind regards
LordBunilla

How to reproduce:

!art [[aven mindcensor e:mp2]] should pull the art from the invocation, it instead shows the newest art (amonkhet) and shows the mp2 card as the card embed

Hi theneosloth

I really appreciate your work with the Bolas bot, as it works really well with queries, and allows fast searches for the cards related to terms, especially for commander brewers like me. We're using it on the r/EDH discord, and there I've noticed two things, specifically regarding the !price command:

The !price command doesn't function well for two types of cards:

1. Cards that only exist in foil (Tymna, the Weaver) [The "usd" in the scryfall api does not contain foil prices, also not for those that only exist in foil.]
2. Cards where the latest release is digital (The Tabernacle at Pendrell Vale) [The scryfall api grabs the digital version for some reason, no matter if you use fuzzy or search.]

For the first one, it would probably just be a matter of also displaying the "usd_foil" price. (And while we're at it, you might as well also show the "eur" price.)

For the second one, this likely needs some rework of the price functionality, but you already used similar methods for the !art command:

• Instead of using the "named" function, use the "search" function, but add a "order:usd" in the beginning of the query (so "q=order:usd [args]"), to filter out digital cards (you would normally use "not:digital", but if someone wants to know the tix price, it wouldn't be optimal).

What happens here is the following in the possible scenarios:

• Someone types in "Blood", you still return "too many cards match the search..."
• Someone types in "Blood Pet", it returns the lowest USD price (usd:0.24, usd_foil:none, eur:0.09, tix:none)
• Someone types in "Blood Pet set:7ed", it returns the price of that version
• Someone types in "Blood Pet order:tix", it overwrites your "order=usd", as providing two times "order" in a query it just selects the last one that is in the query, thus it provides the lowest TIX price
• Someone types in "Tymna, the Weaver", it returns the price of the foil card, and not the digital card, despite both having usd:none, the scryfall API seems to know what you want here, which is good!

Kind regards
LordBunilla

The current implementation of the card search is not asynchronous, which I suspect is causing some bottlenecks. Instead of re-implementing the api wrapper it might be better to use the scrython library

Right now bolas contains a large number of hard coded server and user specific values that cannot be changed without updating the code. It would be better to store these values in a separate database.

Currently all the commands are located within a single file. This was working well for when there were only a few of them but as more and more of them get added managing the file gets a little bit unwieldy.

Because all the files inherited from the CommandPlugin class are imported automatically this should be trivial to do and it would improve the readability of the code immensely.

Trying to look up art (again) and it's pulling thew wrong one. Try [[dark ritual a:guay]], it pulls the wrong art

Searching for [[gix]] only brings up the card called Gix, rather than all cards with gix in the title, of which there are 4 as seen here. https://scryfall.com/search?q=gix

Since https://archidekt.com/ is becoming very popular with the EDH crowd, would be nice to have !diff accept lists from there as well