themattrix / docker-tox-base Goto Github PK

I've been playing with docker-tox on Circle CI and I've run into the problem that currently pypy is pypy 3.3:

root@d3b024b08537:/app# pypy
Python 3.3.5 (ea9979b550eeae87924dc4bef06070e8f8d0e22f, Oct 13 2016, 11:32:23)
[PyPy 5.5.0-alpha0 with GCC 6.2.0] on linux
...
root@d3b024b08537:/app# pypy3
Python 3.5.3 (fdd60ed87e94, Apr 24 2018, 06:10:04)
[PyPy 6.0.0 with GCC 6.2.0 20160901] on linux

That's most likely caused by 6a15495

I guess kill off the penultimate line?

And maybe update the other versions while at it (notably 3.7.2)? 😇

First, thanks for the base and the actual tox package. It enabled me to use my usual tox configuration directly with docker images. That's excellent work!

Now I have request and a question of understanding:
We are currently at a version 5.8.0 for PyPy3 which actually is compatible with CPython 3.5. It would be nice to have that included here. Unfortunately I do not understand where the python-versions.txt is somehow read or included in the build process. Is it just the change of the version number in this file?

New version od Python was relesed. https://docs.python.org/3/whatsnew/3.7.html

I tried using docker-tox with a project that already includes a .python-version file for local development. This seems to break docker-tox since pyenv in the container will then try to find those environments for running tox.

I guess docker-entrypoint.sh should just exclude this file if it happens to exist, but I didn't test this further.