theleagueof / league-spartan Goto Github PK

Hello,
I was wondering if you were taking glyph contributions and if so, what format you would like them. I'd like to add Kurdish and Turkish letters. You have the components for most of them anyhow, like you have ç but not ş.

Double-storey 'a' as an alternative?

• AUTHORS.txt : Names listed there is what will appear as "designers" in the GF specimen page. It should include the original author Matt Bailey and all contributing designers. You can also have "The League Of" as a collective.
• CONTRIBUTORS.txt : people who contributed on a non-design level.
• README.md: General update + include the original repo with mention of Matt Bailey.

@sursly tagged a 2.4 release on his fork, but it is based on the version of the repo before I added Fontship release stuff here. The changes in there need to be cherry picked or rebased into the current repository and a 2.400 release tagged.

(Tyler if you start new work in up to date branches from the latest upstream version instead of your old ones this wouldn't need doing, wink wink. I can take care of this, but it would be a lot smoother if you just could open a PR to submit new work and then tag here and be done with the release process.)

I think we ran into this on Raleway too, but one of the things we're doing as part of Fontship’s build process is using the normalization and fixup tools in gftools (Google Fonts' toolkit). It has gotten a little bit stricter since we released v2.210. If still builds with the old Docker image of Fontship (v0.3.4), but trying to upgrade it to anything newer (such as the current v0.5.0 or master branch) fails:

File "/usr/bin/gftools-fix-vf-meta.py", line 167, in update_nametable
raise ValueError(f"Unsupported wght coord '{wght_val}'. Coord "
ValueError: Unsupported wght coord '277.0'. Coord needs to be in {WGHT.keys()}

It'd be great to ship a build script to create the four weights of sursly from the sources of the font.

I'm not able to build some weights with fontmake, neither with -g (glyph) nor -u (ufo)

Hi. Thank you for open sourcing the typeface.

Would you consider releasing it to Google Fonts?

Guide can be found here: https://github.com/googlefonts/gf-docs/tree/master/Spec#upstream-repos

I'm seeing an issue that makes it hard to use this font as a replacement for other sans-serif fonts. At 13px, it appears to be occupying around 11px, with the box taking up 12px.

Example code:

        <div style="font-family: Spartan" class="font-div">League Spartan 13px</div>
        <div style="font-family: Helvetica" class="font-div">Helvetica 13px</div>
        <div style="font-family: Arial" class="font-div">Arial 13px</div>

@font-face {
    font-family: "Spartan";
    src: url("@/assets/fonts/LeagueSpartan-VF.woff2") format('woff2-variations');
    font-weight: 200 900;
}

.font-div {
    font-size: 13px;
    line-height: normal;
}

Result on my MacBook in Chrome:

Is there a reason _webfonts/stylesheet.css is chmod +x?

A user wrote me,

Dear Google Fonts,

I noticed that one of your variable fonts have an error, specifically Spartan Variable.
https://t.co/IvVmVJZ2KZ

The normal non-variable Spartan set is fine, but the variable has an issues where the character "u" and it's alternatives (like ú, ü, ű etc.) are too high compared to other characters. This happens from weights 501 to 899. The 500 (medium) and 900 (black) are fine, but the ones between them are incorrectly sized.

It's weird, because the preview on your website and in a font manager software this doesn't occur, the font looks absolutely fine. This issue comes alive only when i actually use the font in Adobe Illustrator or Photoshop. Haven't tried other software tho, but other variable fonts work fine.

I don't know how much control you have, considering it's made by someone else outside of Google i assume, but i hope you can fix this. Thanks!

Similar to theleagueof/raleway#17 the variable font builds seem to use the first named instance as the family name, which makes this project's VF is rendered “League Spartan Extralight”. Not so smooth for something with a weight axis that goes to 900.

Having poked at his a little I don't think it's even a bug in Fontship, I think it goes all the way up the tree to fontmake. But wherever the bug is and however it gets fixed a new release should be done for this font when this is taken care of.

would they be hard to add?

From the home page:

Taking a strong influence from ATF's classic Spartan family, we're starting our own family out with a single strong weight. We've put a few unique touches into a beautiful, historical typeface, and made sure to include an extensive characterset – currently totaling over 300 glyphs.

Over time, the open-source license will allow us expand League Spartan into a full family, with multiple weights and styles, and we're starting by releasing our first Bold style for this exciting, modern classic now.

Has there been any progress on this? Is there a way I could make a small monetary contribution to support this work? I would really like to get a normal weight version.

See also #7

Hello!

This is an automatically-generated report about possible interpolation problems in LeagueSpartan[wght].ttf, as found in the Google Fonts catalog.

To download a PDF version of this report with helpful visuals of the problems, click here; Or to view it on the GitHub website, click here.

The report follows:

Glyph .notdef was not compatible:
  Masters: '', 'wght=500.0':
    Contour order differs: [0, 1, 2] in '', [1, 0, 2] in 'wght=500.0'
    Contour 0 start point differs: 0 in '', 1 in 'wght=500.0'; reversed: False
    Contour 1 start point differs: 0 in '', 1 in 'wght=500.0'; reversed: False
    Contour 2 start point differs: 0 in '', 0 in 'wght=500.0'; reversed: True

This report was generated using the fonttools varLib.interpolatable tool. We understand that sometimes the tool generates false-positives. Particularly for more complicated font designs. If you did not find this report useful, please accept our apologies and ignore / close it.

To give feedback about this report, please file an issue or open a discussion at fonttools.

In Microsoft Word, the diacritics of uppercase letters do not appear.
The following image shows the letters Ã, À, and Ê in League Spartan:

Shouldn't the CSS refer to the SVG font id as league_spartanregular instead of league_spartanbold?